Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly too complicated activity diagram for adding student in DG #12

Open
fymbc opened this issue Nov 8, 2024 · 0 comments
Open

Slightly too complicated activity diagram for adding student in DG #12

fymbc opened this issue Nov 8, 2024 · 0 comments

Comments

@fymbc
Copy link
Owner

fymbc commented Nov 8, 2024

I think the activity diagram is extremely comprehensive, which is good in some ways!

This is subjective but in my opinion,

  1. Some steps can be coalesced. Accept and execute user input (first two steps) can be combined (maybe even with parse) to make it simpler. A more high-level activity diagram can be more palatable for readers. Likewise for creating student, creating AddCommand object, etc.

  2. In relation to point 1 on high-level, I think we can abstract out the exact implementation and instead write it more generically (e.g. MESSAGE_USAGE, etc), to place less focus on variable names and more on its purpose.

  3. [Minor] For invalid arg format maybe spell out to argument? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant