You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think the activity diagram is extremely comprehensive, which is good in some ways!
This is subjective but in my opinion,
Some steps can be coalesced. Accept and execute user input (first two steps) can be combined (maybe even with parse) to make it simpler. A more high-level activity diagram can be more palatable for readers. Likewise for creating student, creating AddCommand object, etc.
In relation to point 1 on high-level, I think we can abstract out the exact implementation and instead write it more generically (e.g. MESSAGE_USAGE, etc), to place less focus on variable names and more on its purpose.
[Minor] For invalid arg format maybe spell out to argument? :)
The text was updated successfully, but these errors were encountered:
I think the activity diagram is extremely comprehensive, which is good in some ways!
This is subjective but in my opinion,
Some steps can be coalesced. Accept and execute user input (first two steps) can be combined (maybe even with parse) to make it simpler. A more high-level activity diagram can be more palatable for readers. Likewise for creating student, creating AddCommand object, etc.
In relation to point 1 on high-level, I think we can abstract out the exact implementation and instead write it more generically (e.g.
MESSAGE_USAGE
, etc), to place less focus on variable names and more on its purpose.[Minor] For
invalid arg format
maybe spell out toargument
? :)The text was updated successfully, but these errors were encountered: