Defer to system theme when a custom theme delegates to DefaultTheme #5231
+172
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I still have to refactor the base config dir code
Jacalz
reviewed
Nov 27, 2024
app/app.go
Outdated
| @@ -172,6 +172,10 @@ func newAppWithDriver(d fyne.Driver, clipboard fyne.Clipboard, id string) fyne.A | |||
| return newApp | |||
| } | |||
|
|
|||
| func rootConfigDir() string { | |||
| return app.RootConfigDir() | |||
There was a problem hiding this comment.
Should we not just call that function directly instead of indirectly through this function?
There was a problem hiding this comment.
Thanks for that :) fixed
Jacalz
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that an app with a partial custom theme will delegate to the builtin theme instead of the rendered one. These can be different if you have a system theme installed.
Checklist: