Fix lang tests
#5292
Open
Fix lang tests
#5292
+31
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `setupLang` call has to happen _after_ the `AddTranslations` call. This was the case in all but one scenario.
andydotxyz
reviewed
Dec 1, 2024
| @@ -203,7 +203,5 @@ func updateLocalizer() { | |||
| fyne.LogError("Failed to load user locales", err) | |||
| all = []string{"en"} | |||
| } | |||
| str := closestSupportedLocale(all).LanguageString() | |||
| setupLang(str) | |||
| localizer = i18n.NewLocalizer(bundle, str) | |||
There was a problem hiding this comment.
Are you sure this was superfluous?
The intention was that it would replace whatever previous configuration was set up...
There was a problem hiding this comment.
setupLang does the exact same thing, see https://github.com/fyne-io/fyne/blob/develop/lang/lang.go#L196
There was a problem hiding this comment.
Excellent, sorry for missing that - I was on my mobile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes a bug in the
langtests forAddTranslationson systems without English system locale.Checklist: