Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review description of the CategoricalVariation.members property #70

Open
mbrush opened this issue Nov 6, 2024 · 4 comments
Open

Review description of the CategoricalVariation.members property #70

mbrush opened this issue Nov 6, 2024 · 4 comments

Comments

@mbrush
Copy link

mbrush commented Nov 6, 2024

The description of the CategoricalVariation.members property reads: "A non-exhaustive list of VRS variation Constraints that satisfy the constraints of this categorical variant." . . . the first 'Constraints' in this definition seems wrong. See here.

Shouldn't the description read "A non-exhaustive list of VRS variations that satisfy the constraints of this categorical variant" . . . or am I not understanding something?

@jsstevenson
Copy link
Contributor

would it be meaningful to capitalize Variation here as well?

@DanielPuthawala
Copy link
Collaborator

@mbrush Thanks for catching that. Yes, that's wrong in exactly the way you describe. I'll fix it.

@DanielPuthawala
Copy link
Collaborator

DanielPuthawala commented Nov 6, 2024

would it be meaningful to capitalize Variation here as well?

uh.... yes iff gks:core/json/IRI objects are all of the same vrs:Variation class as well, which I think is the case. @ahwagner is that right, that all gkscore:IRI objects are ultimately vrs:Variations?

Copy link
Contributor

Yes, please change and create a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants