Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git ref imports #30

Open
wants to merge 5 commits into
base: git-ref-imports
Choose a base branch
from

Conversation

tnavatar
Copy link
Collaborator

@tnavatar tnavatar commented Nov 5, 2024

Allows use of git refs for imported schema, rather than relying on Git submodules.

@larrybabb larrybabb requested a review from ahwagner November 7, 2024 01:19
Copy link
Member

@ahwagner ahwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a useful feature addition towards removing git submodules.

However, this breaks assumptions about the version of the source schema file with respect to imported artifacts from upstream repositories. If a downstream repository uses a different version of metaschema processor, it may result in different reprocessed artifacts, causing potential sync issues.

I request that this is merged into a feature branch (not main) on ga4gh/gks-metaschema until such a time as supplemental features can be added to bring this approach to parity with git submodule.

@tnavatar
Copy link
Collaborator Author

tnavatar commented Nov 7, 2024

However, this breaks assumptions about the version of the source schema file with respect to imported artifacts from upstream repositories. If a downstream repository uses a different version of metaschema processor, it may result in different reprocessed artifacts, causing potential sync issues.

Could you be a little more specific about how this could come about? A concrete example would help me to understand.

One thing I can see that this would break is if an upstream repository itself has imports included with git submodules. These would effectively be unresolvable. I don't think this can be fixed, I think it simply has to be unsupported to include a library via git refs that has dependencies declared via git submodules.

@tnavatar tnavatar changed the base branch from main to git-ref-imports November 7, 2024 11:53
@tnavatar
Copy link
Collaborator Author

tnavatar commented Nov 7, 2024

In the meantime, happy to accept your suggestion to merge it into a feature branch in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants