Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of innerHTML #88

Open
PxlBuzzard opened this issue May 24, 2016 · 0 comments
Open

Fix usage of innerHTML #88

PxlBuzzard opened this issue May 24, 2016 · 0 comments
Labels

Comments

@PxlBuzzard
Copy link
Collaborator

After a full review by the Mozilla Addon team, they have 1 issue to report:

This add-on is creating DOM nodes from HTML strings containing potentially unsanitized data, by assigning to innerHTML, jQuery.html, or through similar means. Aside from being inefficient, this is a major security risk. For more information, see https://developer.mozilla.org/en/XUL_School/DOM_Building_and_HTML_Insertion. Here are some examples that were discovered:

https://github.com/gabrielecirulli/hn-special/blob/master/lib/modules/user_tooltips.js#L43

@PxlBuzzard PxlBuzzard changed the title Fix usage of innerHTML [Bug] Fix usage of innerHTML Jul 11, 2016
@gabrielecirulli gabrielecirulli changed the title [Bug] Fix usage of innerHTML Fix usage of innerHTML Jul 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants