Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new resource attributes and increase performance #30

Merged
merged 10 commits into from
Sep 1, 2023
Merged

Add new resource attributes and increase performance #30

merged 10 commits into from
Sep 1, 2023

Conversation

gacou54
Copy link
Owner

@gacou54 gacou54 commented Aug 30, 2023 •
edited
Loading

New attributes:

  • Patient.birth_date
  • Patient.OtherPatientIDs
  • Study.description
  • Study.institution_name
  • Study.requested_procedure_description
  • Study.requesting_physician
  • Series.performed_procedure_step_description
  • Series.protocol_name
  • Series.station_name
  • Series.body_part_examined
  • Series.sequence_name
  • Series.cardiac_number_of_images
  • Series.images_in_acquisition
  • Series.number_of_temporal_positions
  • Series.number_of_slices
  • Series.number_of_time_slices
  • Series.image_orientation_patient
  • Series.series_type
  • Series.acquisition_device_processing_description
  • Series.operators_name
  • Series.contrast_bolus_agent
  • Instance.acquisition_number
  • Instance.image_orientation_patient
  • Instance.image_position_patient
  • Instance.instance_number
  • Instance.image_comments
  • Instance.number_of_frames
  • Instance.temporal_position_identifier

Performance enhancements:

  • Divided by 2 the number of HTTP calls when going down in the resource levels when resources are locked

API changes:

  • Renaming RemoteModality for Modality while maintaining an alias for backward compatibility
  • Put many internal files as "private" (e.g. filtering.py -> _filtering.py)

@gacou54
Copy link
Owner Author

gacou54 commented Aug 30, 2023

related to #21

@gacou54 gacou54 merged commit f8d2c22 into main Sep 1, 2023
1 check passed
@gacou54 gacou54 mentioned this pull request Sep 1, 2023
Closed
@gacou54 gacou54 deleted the feature/study-description branch September 1, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gacou54