Add easy access to parent rescources and shared-tags #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylemarechal
reviewed
Nov 28, 2023
pyorthanc/_resources/study.py
Outdated
| def get_shared_tags(self, simplify: bool = False, short: bool = False) -> Dict: | ||
| """Retrieve the shared tags of the study""" | ||
| if simplify and not short: | ||
| params = {'simplify': True} |
There was a problem hiding this comment.
I think you could put these verifications in get_series_id_shared_tags (or a dedicated def ortherwise), to avoid code duplication
There was a problem hiding this comment.
Since get_series_id_shared_tags is in the generated client, I am not sure it is a good idea to change it?
There was a problem hiding this comment.
You are right. Still I would put this business rule in a dedicated function.
I'm not sure if it is the best solution.
ylemarechal
approved these changes
Nov 29, 2023
ylemarechal
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features:
parent_(patient/study/series)property that facilitate the access to its parent resourcesshared_tagsproperty that retrieve the shared tags in a simplified formatget_shared_tags(simplify=True/False, short=True/False)method is also accessible