-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Microsoft.PowerShell.PlatyPS module #497
Comments
It is probably DscResource.DocGenerator tasks that need to be refactored. Are the tasks that runs PlatyPS in Sampler used by anyone? |
I still use this one: https://github.com/gaelcolas/Sampler/blob/main/.build/tasks/generateHelp.PlatyPS.build.ps1. If you want, I can take a look and rewrite it. |
How much refactor will be needed? Thinking if there gonna be any breaking changes 🤔 But please send in a PR 😊 |
Tbh, I already wanted to write some code, but spend my time around the The new |
That problem already exist with the current PlatyPS and is solved by running PlatyPS in a separate session so it is the only module using the dlls. Might need to do the same with this new module. |
Do you mind sharing an example Johan? I tried searching for it, but couldn't find it :( |
It’s in the existing task
|
Clearly I wasn't watching with my eyes, thanks Johan. |
Also, if you adding a new task, maybe look at DscResource.DocGenerator module and those tasks that generate help for public commands and external help and see if we should remove tasks there that will be covered by any changes here. |
Is it the parameter |
Problem description
With the preview release of
Microsoft.PowerShell.PlatyPS
, it would be great to include it in theRequiredModules.psd1
and move the task logic to use the new commands.Verbose logs
How to reproduce
N/A
Expected behavior
Use
Microsoft.PowerShell.PlatyPS
.Current behavior
Uses
PlatyPS
Suggested solution
Change the
RequiredModules.psd1
to include the module. Update the relevant doc tasks.Operating system the target node is running
PowerShell version and build the target node is running
Module version used
The text was updated successfully, but these errors were encountered: