Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inky components do not render valid <table> HTML #18

Open
lawsumisu opened this issue Oct 19, 2018 · 1 comment
Open

Inky components do not render valid <table> HTML #18

lawsumisu opened this issue Oct 19, 2018 · 1 comment

Comments

@lawsumisu
Copy link

I make use of react-inky to generate email style templates, and I use enzyme to write unit tests for them. When I run my tests, I get warnings like:

Warning: validateDOMNesting(...): <tr> cannot appear as a child of <table>. Add a <tbody> to your code to match the DOM tree generated by the browser.

It seems like many of the components that use <table> tags do not include <tbody> tags to contain <tr> elements. Being a warning, this is more of a nuisance than a real issue, but would it be unreasonable to update all the Inky components to render valid tables?

@gakimball
Copy link
Owner

react-inky imitates the original inky library exactly, so it doesn't use thead or tbody.

I have added a non-strict mode where we can add things that deviate from the original inky library. However, I'm not sure if adding these tags would break things in any clients that Foundation for Emails supports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants