This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
Allow setting of gherkin terminal size using zos3270.gherkin.terminal.rows and zos3270.gherkin.terminal.columns, or in the gherkin scenario itself. #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….rows and zos3270.gherkin.terminal.columns, or in the gherkin scenario itself. Signed-off-by: Mike Cobbett <[email protected]>
|
Build successful |
eamansour
approved these changes
Jul 26, 2024
| int rows ; | ||
| rows = getNumericCPSProperty("zos3270.gherkin.terminal.rows",DEFAULT_TERMINAL_ROWS,rowsStepParameter); | ||
| columns = getNumericCPSProperty("zos3270.gherkin.terminal.columns",DEFAULT_TERMINAL_COLUMNS,rowsColumnParameter); | ||
| logger.info("Preferred terminal size is "+Integer.toString(rows)+" x "+Integer.toString(columns)); |
There was a problem hiding this comment.
Rows and columns might need swapping for this log message - for example with 24 rows and 80 columns, this would read as 24 x 80 instead of 80 x 24
There was a problem hiding this comment.
I do wonder whether mainframers use 24x80
This is from host on demand:
There was a problem hiding this comment.
Adam Coulthard
Its normally 24 x 80 rows and columns
|
Build successful |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mike Cobbett [email protected]
Why ?
See story galasa-dev/projectmanagement#1708