-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for fits_image_viewer visualization plugin #17002
Fix for fits_image_viewer visualization plugin #17002
Conversation
Following advice from galaxy maintainer : - Switch to cpy-cli to use instead of cp (should prevent the differences in cp behaviour)
@dannon are you happy with the changes we made to the pr or is there some other thing you want us to modify? |
@francoismg This looks fine -- sorry for the slow response, I was out most of last week. We expect to freeze for 23.2 today or tomorrow, so this update will be included and deployed on usegalaxy servers soon after the release. |
This PR was merged without a "kind/" label, please correct. |
Thanks for the response that sounds great |
The fits_image_viewer (used for visualization of FITS file) has been unusable on usegalaxy.eu and on some local instances.
Two differents bugs are causing this issue (more details can be found in this issue usegalaxy-eu#194) :
This fix makes the plugin relies on the university of strasbourg CDN (which should be a workaround for the server mime type issue) with a fallback to local aladin lite js files if the cdn were not to be available.
The second fix is to force the creation of the aladin lite folder directly on the build script in order to resolve the issue that on some instances the folder was not created correctly which caused some missing js files error
@bgruening since the plugin is not usable right now on galaxy.eu we were wondering what kind of timeframe we should expect for the fix to be pushed to galaxy.eu prod, thanks
How to test the changes?
License