Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for fits_image_viewer visualization plugin #17002

Merged
merged 5 commits into from
Nov 27, 2023

Conversation

francoismg
Copy link
Contributor

The fits_image_viewer (used for visualization of FITS file) has been unusable on usegalaxy.eu and on some local instances.

Two differents bugs are causing this issue (more details can be found in this issue usegalaxy-eu#194) :

  • The first one is only related to the usegalaxy.eu server that doesn't serve the correct mime type for web assembly file
  • The second one is caused by the aladin lite js files not being copied to the correct location.

This fix makes the plugin relies on the university of strasbourg CDN (which should be a workaround for the server mime type issue) with a fallback to local aladin lite js files if the cdn were not to be available.

The second fix is to force the creation of the aladin lite folder directly on the build script in order to resolve the issue that on some instances the folder was not created correctly which caused some missing js files error

@bgruening since the plugin is not usable right now on galaxy.eu we were wondering what kind of timeframe we should expect for the fix to be pushed to galaxy.eu prod, thanks

How to test the changes?

  • Instructions for manual testing are as follows:
    1. Upload a fits file to galaxy (one should be present on the test-data folder)
    2. Use the visualization plugin to open the fits file (after a few second a map of space should be displayed with the content of the file in the middle)

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Following advice from galaxy maintainer :

- Switch to cpy-cli to use instead of cp (should prevent the differences in cp behaviour)
@francoismg francoismg marked this pull request as draft November 13, 2023 06:04
@francoismg francoismg marked this pull request as ready for review November 13, 2023 13:48
@francoismg
Copy link
Contributor Author

@dannon are you happy with the changes we made to the pr or is there some other thing you want us to modify?
If everything seems ok to you do you know in what kind of timeframe we can expect it to be merged? There might be some tool demo soon and it would be nice if participants can test the tool themselves on the usegalaxy instance. Thanks

@dannon
Copy link
Member

dannon commented Nov 27, 2023

@francoismg This looks fine -- sorry for the slow response, I was out most of last week. We expect to freeze for 23.2 today or tomorrow, so this update will be included and deployed on usegalaxy servers soon after the release.

@dannon dannon merged commit 8c48e46 into galaxyproject:dev Nov 27, 2023
47 checks passed
Copy link

This PR was merged without a "kind/" label, please correct.

@francoismg
Copy link
Contributor Author

@francoismg This looks fine -- sorry for the slow response, I was out most of last week. We expect to freeze for 23.2 today or tomorrow, so this update will be included and deployed on usegalaxy servers soon after the release.

Thanks for the response that sounds great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants