From 1d839e84e3d3c54a628f7a74bc8d79243505365c Mon Sep 17 00:00:00 2001
From: John Chilton <jmchilton@gmail.com>
Date: Fri, 22 Nov 2024 09:51:04 -0500
Subject: [PATCH 01/17] Cleanup debug logging in terminal.ts.

---
 .../Workflow/Editor/modules/terminals.test.ts        | 12 ++++++++++++
 .../components/Workflow/Editor/modules/terminals.ts  |  5 ++++-
 2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/client/src/components/Workflow/Editor/modules/terminals.test.ts b/client/src/components/Workflow/Editor/modules/terminals.test.ts
index f72e83896ab7..8cfe67082545 100644
--- a/client/src/components/Workflow/Editor/modules/terminals.test.ts
+++ b/client/src/components/Workflow/Editor/modules/terminals.test.ts
@@ -25,6 +25,7 @@ import {
     InputParameterTerminal,
     InputTerminal,
     InvalidOutputTerminal,
+    NO_COLLECTION_TYPE_INFORMATION_MESSAGE,
     OutputCollectionTerminal,
     OutputParameterTerminal,
     OutputTerminal,
@@ -50,6 +51,17 @@ function useStores(id = "mock-workflow") {
     };
 }
 
+// Suppress debug messages about node configurations, we're testing esoteric things here -
+// we might want these messages at runtime to help debug complex things but we don't need it
+// during unit testing.
+jest.spyOn(console, "debug").mockImplementation(
+    jest.fn((msg) => {
+        if (msg != NO_COLLECTION_TYPE_INFORMATION_MESSAGE) {
+            console.debug(msg);
+        }
+    })
+);
+
 function setupAdvanced() {
     const terminals: { [index: string]: { [index: string]: ReturnType<typeof terminalFactory> } } = {};
 
diff --git a/client/src/components/Workflow/Editor/modules/terminals.ts b/client/src/components/Workflow/Editor/modules/terminals.ts
index 49effcb402fe..8221133278df 100644
--- a/client/src/components/Workflow/Editor/modules/terminals.ts
+++ b/client/src/components/Workflow/Editor/modules/terminals.ts
@@ -21,6 +21,9 @@ import {
     NULL_COLLECTION_TYPE_DESCRIPTION,
 } from "./collectionTypeDescription";
 
+export const NO_COLLECTION_TYPE_INFORMATION_MESSAGE =
+    "No collection type or collection type source defined - this is fine but may lead to less intuitive connection logic.";
+
 export class ConnectionAcceptable {
     reason: string | null;
     canAccept: boolean;
@@ -757,7 +760,7 @@ export class OutputCollectionTerminal extends BaseOutputTerminal {
         } else {
             this.collectionTypeSource = attr.collection_type_source;
             if (!this.collectionTypeSource) {
-                console.log("Warning: No collection type or collection type source defined.");
+                console.debug(NO_COLLECTION_TYPE_INFORMATION_MESSAGE);
             }
             this.collectionType = this.getCollectionTypeFromInput() || ANY_COLLECTION_TYPE_DESCRIPTION;
         }

From 20c8f2b396a277ee2e0d47b78c4f324d4972eb51 Mon Sep 17 00:00:00 2001
From: John Chilton <jmchilton@gmail.com>
Date: Fri, 22 Nov 2024 10:02:57 -0500
Subject: [PATCH 02/17] Get rid of scary icon warnings when running
 EditSecretsForm.test.ts

---
 client/src/components/ConfigTemplates/VaultSecret.vue | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/client/src/components/ConfigTemplates/VaultSecret.vue b/client/src/components/ConfigTemplates/VaultSecret.vue
index fe231af18417..4c6140ddbbb9 100644
--- a/client/src/components/ConfigTemplates/VaultSecret.vue
+++ b/client/src/components/ConfigTemplates/VaultSecret.vue
@@ -1,9 +1,14 @@
 <script setup lang="ts">
+import { library } from "@fortawesome/fontawesome-svg-core";
+import { faPen } from "@fortawesome/free-solid-svg-icons";
+import { FontAwesomeIcon } from "@fortawesome/vue-fontawesome";
 import { BButton, BFormInput, BInputGroup, BInputGroupAppend } from "bootstrap-vue";
 import { computed, ref } from "vue";
 
 import { markup } from "@/components/ObjectStore/configurationMarkdown";
 
+library.add(faPen);
+
 interface Props {
     name: string;
     label: string;
@@ -43,7 +48,7 @@ async function onOk() {
                         <BFormInput type="password" value="*****************************" disabled @click="onClick" />
                         <BInputGroupAppend>
                             <BButton @click="onClick">
-                                <icon icon="edit" />
+                                <FontAwesomeIcon :icon="faPen" />
                                 Update
                             </BButton>
                         </BInputGroupAppend>

From c66fc1bc013d7e50a8a322bd8dd91d63390b9b1a Mon Sep 17 00:00:00 2001
From: John Chilton <jmchilton@gmail.com>
Date: Fri, 22 Nov 2024 10:06:36 -0500
Subject: [PATCH 03/17] Fix test debugging of unregistered Icon in
 DataDialog.test.js

---
 client/src/components/DataDialog/DataDialog.test.js | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/client/src/components/DataDialog/DataDialog.test.js b/client/src/components/DataDialog/DataDialog.test.js
index 09e64d42dca8..5906804e14f2 100644
--- a/client/src/components/DataDialog/DataDialog.test.js
+++ b/client/src/components/DataDialog/DataDialog.test.js
@@ -134,6 +134,9 @@ describe("DataDialog.vue", () => {
         wrapper = shallowMount(DataDialog, {
             propsData: mockOptions,
             localVue,
+            stubs: {
+                Icon: true,
+            },
         });
         expect(wrapper.findComponent(SelectionDialog).exists()).toBe(true);
         // Cannot get nested slot templates to render into the wrapper

From aad8b5576a915d7d08eeafa0ee457a54cc66d569 Mon Sep 17 00:00:00 2001
From: John Chilton <jmchilton@gmail.com>
Date: Fri, 22 Nov 2024 10:12:42 -0500
Subject: [PATCH 04/17] Pass required scroll prop in Node.test.ts.

---
 client/src/components/Workflow/Editor/Node.test.ts | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/client/src/components/Workflow/Editor/Node.test.ts b/client/src/components/Workflow/Editor/Node.test.ts
index 959a38e65869..8b85f647a06f 100644
--- a/client/src/components/Workflow/Editor/Node.test.ts
+++ b/client/src/components/Workflow/Editor/Node.test.ts
@@ -14,6 +14,12 @@ jest.mock("app");
 
 const localVue = getLocalVue();
 
+const MOCK_SCROLL = {
+    x: { value: 100 },
+    y: { value: 200 },
+    isScrolling: { value: true },
+};
+
 describe("Node", () => {
     it("test attributes", async () => {
         const testingPinia = createTestingPinia();
@@ -27,6 +33,7 @@ describe("Node", () => {
                 step: { type: "tool", inputs: [], outputs: [], position: { top: 0, left: 0 } },
                 datatypesMapper: testDatatypesMapper,
                 rootOffset: mockOffset,
+                scroll: MOCK_SCROLL,
             },
             localVue,
             pinia: testingPinia,

From ad5e0d58e4a98f900be4e4917f362331b91a8cb2 Mon Sep 17 00:00:00 2001
From: John Chilton <jmchilton@gmail.com>
Date: Fri, 22 Nov 2024 10:19:11 -0500
Subject: [PATCH 05/17] Cleanup test output for HistoryExport.test.ts.

---
 client/src/components/History/Export/HistoryExport.test.ts | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/client/src/components/History/Export/HistoryExport.test.ts b/client/src/components/History/Export/HistoryExport.test.ts
index e4827c4e0fe7..1489458270cd 100644
--- a/client/src/components/History/Export/HistoryExport.test.ts
+++ b/client/src/components/History/Export/HistoryExport.test.ts
@@ -1,5 +1,5 @@
 import { createTestingPinia } from "@pinia/testing";
-import { getLocalVue } from "@tests/jest/helpers";
+import { getLocalVue, suppressDebugConsole } from "@tests/jest/helpers";
 import { shallowMount } from "@vue/test-utils";
 import flushPromises from "flush-promises";
 import { setActivePinia } from "pinia";
@@ -164,6 +164,8 @@ describe("HistoryExport.vue", () => {
     });
 
     it("should not display a fatal error alert if the history is found and loaded", async () => {
+        suppressDebugConsole(); // we rightfully debug message the fact we don't have a history in this test
+
         const wrapper = await mountHistoryExport();
 
         expect(wrapper.find("#fatal-error-alert").exists()).toBe(false);

From 66a9cc755445491d8b655895331e21db6b86a894 Mon Sep 17 00:00:00 2001
From: John Chilton <jmchilton@gmail.com>
Date: Fri, 22 Nov 2024 10:23:02 -0500
Subject: [PATCH 06/17] Fix mock setup in FromFileOrUrl to cleanup scary/valid
 errors in test output.

---
 client/src/components/Workflow/Import/FromFileOrUrl.test.ts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/client/src/components/Workflow/Import/FromFileOrUrl.test.ts b/client/src/components/Workflow/Import/FromFileOrUrl.test.ts
index c7cda693970e..aca8dcaad8b0 100644
--- a/client/src/components/Workflow/Import/FromFileOrUrl.test.ts
+++ b/client/src/components/Workflow/Import/FromFileOrUrl.test.ts
@@ -9,6 +9,7 @@ jest.mock("axios", () => ({
     post: jest.fn((_url, request) => {
         lastPostRequest = request;
     }),
+    isAxiosError: jest.fn(() => true),
 }));
 
 const localVue = getLocalVue(true);

From 48b389b14de03d2c99ca4af3f7489b058ccdbebc Mon Sep 17 00:00:00 2001
From: John Chilton <jmchilton@gmail.com>
Date: Fri, 22 Nov 2024 10:25:49 -0500
Subject: [PATCH 07/17] Better abstractions, less output in
 SelectionOperations.test.js.

---
 .../HistoryOperations/SelectionOperations.test.js    | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/client/src/components/History/CurrentHistory/HistoryOperations/SelectionOperations.test.js b/client/src/components/History/CurrentHistory/HistoryOperations/SelectionOperations.test.js
index de5c632e5b2e..c7f9594cf230 100644
--- a/client/src/components/History/CurrentHistory/HistoryOperations/SelectionOperations.test.js
+++ b/client/src/components/History/CurrentHistory/HistoryOperations/SelectionOperations.test.js
@@ -1,7 +1,8 @@
 import { shallowMount } from "@vue/test-utils";
 import flushPromises from "flush-promises";
 import { createPinia } from "pinia";
-import { getLocalVue } from "tests/jest/helpers";
+import { getLocalVue, suppressDebugConsole } from "tests/jest/helpers";
+import { setupMockConfig } from "tests/jest/mockConfig";
 
 import { useServerMock } from "@/api/client/__mocks__";
 
@@ -32,11 +33,7 @@ const getDeletedSelection = () => new Map([["FAKE_ID", { deleted: true }]]);
 const getActiveSelection = () => new Map([["FAKE_ID", { deleted: false }]]);
 
 async function mountSelectionOperationsWrapper(config) {
-    server.use(
-        http.get("/api/configuration", ({ response }) => {
-            return response(200).json(config);
-        })
-    );
+    setupMockConfig(config);
 
     const pinia = createPinia();
     const wrapper = shallowMount(SelectionOperations, {
@@ -269,6 +266,7 @@ describe("History Selection Operations", () => {
             });
 
             it("should update operation-running state to null when the operation fails", async () => {
+                suppressDebugConsole(); // expected error messages since we're testing errors.
                 server.use(
                     http.put("/api/histories/{history_id}/contents/bulk", ({ response }) => {
                         return response("4XX").json({ err_msg: "Error", err_code: 400 }, { status: 400 });
@@ -290,6 +288,8 @@ describe("History Selection Operations", () => {
             });
 
             it("should emit operation error event when the operation fails", async () => {
+                suppressDebugConsole(); // expected error messages since we're testing errors.
+
                 server.use(
                     http.put("/api/histories/{history_id}/contents/bulk", ({ response }) => {
                         return response("4XX").json({ err_msg: "Error", err_code: 400 }, { status: 400 });

From 61a92671dd8a152ef247df8c23f98f181bca1dcf Mon Sep 17 00:00:00 2001
From: John Chilton <jmchilton@gmail.com>
Date: Fri, 22 Nov 2024 10:35:43 -0500
Subject: [PATCH 08/17] Less chatty "Galaxy console" when jest testing.

---
 client/src/app/monitor.js    |  4 +++-
 client/src/onload/console.js | 11 ++++++++---
 2 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/client/src/app/monitor.js b/client/src/app/monitor.js
index 3de7d0dfd212..81b39097c72f 100644
--- a/client/src/app/monitor.js
+++ b/client/src/app/monitor.js
@@ -27,7 +27,9 @@ if (!window.Galaxy) {
         },
     });
 } else {
-    console.debug("Skipping, window.Galaxy already exists.", serverPath());
+    if (process.env.NODE_ENV != "test") {
+        console.debug("Skipping, window.Galaxy already exists.", serverPath());
+    }
 }
 
 export default window.Galaxy;
diff --git a/client/src/onload/console.js b/client/src/onload/console.js
index 3cc2afb908d9..96f1570eb290 100644
--- a/client/src/onload/console.js
+++ b/client/src/onload/console.js
@@ -9,9 +9,12 @@ import { watch } from "vue";
 
 export function overrideProductionConsole() {
     let defaultEnabled = true;
+    let runningTest = false;
 
     if (process.env.NODE_ENV == "production") {
         defaultEnabled = false;
+    } else if (process.env.NODE_ENV == "test") {
+        runningTest = true;
     }
 
     const isEnabled = useLocalStorage("console-debugging-enabled", defaultEnabled);
@@ -31,9 +34,11 @@ export function overrideProductionConsole() {
     };
 
     const enableConsole = () => {
-        console.log(
-            "The Galaxy console has been enabled.  You can disable it by running disableDebugging() in devtools."
-        );
+        if (!runningTest) {
+            console.log(
+                "The Galaxy console has been enabled.  You can disable it by running disableDebugging() in devtools."
+            );
+        }
         if (storedConsole) {
             // eslint-disable-next-line no-global-assign
             console = storedConsole;

From f08c0b15e1f3bfeffe7d61193a57cb31fef6f997 Mon Sep 17 00:00:00 2001
From: John Chilton <jmchilton@gmail.com>
Date: Fri, 22 Nov 2024 10:46:39 -0500
Subject: [PATCH 09/17] Fix missing properties in InstanceForm.test.ts.

---
 client/src/components/ConfigTemplates/InstanceForm.test.ts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/client/src/components/ConfigTemplates/InstanceForm.test.ts b/client/src/components/ConfigTemplates/InstanceForm.test.ts
index f11499ae445c..72b7578cf125 100644
--- a/client/src/components/ConfigTemplates/InstanceForm.test.ts
+++ b/client/src/components/ConfigTemplates/InstanceForm.test.ts
@@ -17,6 +17,8 @@ describe("InstanceForm", () => {
                 title: "MY FORM",
                 inputs: null,
                 submitTitle: SUBMIT_TITLE,
+                busy: false,
+                loadingMessage: "loading plugin instance",
             },
             localVue,
         });
@@ -31,6 +33,8 @@ describe("InstanceForm", () => {
                 title: "MY FORM",
                 inputs: inputs,
                 submitTitle: SUBMIT_TITLE,
+                busy: false,
+                loadingMessage: "loading plugin instance",
             },
             localVue,
         });

From d8ff872549d9ccd238b034c43d545feb58888f52 Mon Sep 17 00:00:00 2001
From: John Chilton <jmchilton@gmail.com>
Date: Fri, 22 Nov 2024 10:46:55 -0500
Subject: [PATCH 10/17] Better config mocking in HistoryView.test.js.

---
 client/src/components/History/HistoryView.test.js | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/client/src/components/History/HistoryView.test.js b/client/src/components/History/HistoryView.test.js
index b00e2647f7a9..0a00dc3ec91a 100644
--- a/client/src/components/History/HistoryView.test.js
+++ b/client/src/components/History/HistoryView.test.js
@@ -3,6 +3,7 @@ import { mount } from "@vue/test-utils";
 import flushPromises from "flush-promises";
 import { createPinia } from "pinia";
 import { getLocalVue } from "tests/jest/helpers";
+import { setupMockConfig } from "tests/jest/mockConfig";
 
 import { useServerMock } from "@/api/client/__mocks__";
 import { useHistoryStore } from "@/stores/historyStore";
@@ -70,11 +71,8 @@ async function createWrapper(localVue, currentUserId, history) {
     setCurrentHistoryOnServer.mockResolvedValue(history);
     const history_contents_result = create_datasets(history.id, history.count);
 
+    setupMockConfig({});
     server.use(
-        http.get("/api/configuration", ({ response }) => {
-            return response(200).json({});
-        }),
-
         http.get("/api/histories/{history_id}/contents", ({ response }) => {
             return response(200).json(history_contents_result);
         })

From 856c909cc996fdc80d27909c0f94355e0407228b Mon Sep 17 00:00:00 2001
From: John Chilton <jmchilton@gmail.com>
Date: Fri, 22 Nov 2024 10:52:38 -0500
Subject: [PATCH 11/17] Another pass at reducing logging around Galaxy configs.

---
 client/src/components/Tool/ToolCard.test.js |  8 ++------
 client/src/stores/configurationStore.ts     |  5 ++++-
 client/tests/jest/helpers.js                | 11 +++++++++++
 3 files changed, 17 insertions(+), 7 deletions(-)

diff --git a/client/src/components/Tool/ToolCard.test.js b/client/src/components/Tool/ToolCard.test.js
index 74b38b1f28e8..2d795e54f62e 100644
--- a/client/src/components/Tool/ToolCard.test.js
+++ b/client/src/components/Tool/ToolCard.test.js
@@ -4,7 +4,7 @@ import MockAdapter from "axios-mock-adapter";
 import flushPromises from "flush-promises";
 import { createPinia } from "pinia";
 import { useUserStore } from "stores/userStore";
-import { getLocalVue } from "tests/jest/helpers";
+import { expectConfigurationRequest, getLocalVue } from "tests/jest/helpers";
 import { setupMockConfig } from "tests/jest/mockConfig";
 
 import { useServerMock } from "@/api/client/__mocks__";
@@ -29,11 +29,7 @@ describe("ToolCard", () => {
         // some child component must be bypassing useConfig - so we need to explicitly
         // stup the API endpoint also. If you can drop this without request problems in log,
         // this hack can be removed.
-        server.use(
-            http.get("/api/configuration", ({ response }) => {
-                return response(200).json(config);
-            })
-        );
+        server.use(expectConfigurationRequest(http, {}));
         axiosMock = new MockAdapter(axios);
         axiosMock.onGet(`/api/webhooks`).reply(200, []);
 
diff --git a/client/src/stores/configurationStore.ts b/client/src/stores/configurationStore.ts
index 85eecffea2bf..72872bd8224f 100644
--- a/client/src/stores/configurationStore.ts
+++ b/client/src/stores/configurationStore.ts
@@ -22,7 +22,10 @@ export const useConfigStore = defineStore("configurationStore", () => {
                 }
 
                 config.value = data;
-                console.debug("Galaxy configuration loaded", config.value);
+                if (process.env.NODE_ENV != "test") {
+                    // an important debug message at runtime but not needed in testing
+                    console.debug("Galaxy configuration loaded", config.value);
+                }
             } finally {
                 isLoading.value = false;
             }
diff --git a/client/tests/jest/helpers.js b/client/tests/jest/helpers.js
index a76a2a7b1191..94cbf8988b7c 100644
--- a/client/tests/jest/helpers.js
+++ b/client/tests/jest/helpers.js
@@ -265,6 +265,17 @@ export function mockModule(storeModule, state = {}) {
     };
 }
 
+/**
+ * Expect and mock out an API request to /api/configuration. In general, useConfig
+ * and using tests/jest/mockConfig is better since components since be talking to the API
+ * directly in this way but some older components are not using the latest composables.
+ */
+export function expectConfigurationRequest(http, config) {
+    return http.get("/api/configuration", ({ response }) => {
+        return response(200).json(config);
+    });
+}
+
 /**
  * Return a new mocked out router attached the specified localVue instance.
  */

From 7609bad18db9faf8f0e7576e9bda7e0ce21ce758 Mon Sep 17 00:00:00 2001
From: John Chilton <jmchilton@gmail.com>
Date: Fri, 22 Nov 2024 11:18:56 -0500
Subject: [PATCH 12/17] More conservative DatasetInformation.test.ts (still
 fails sometimes).

---
 .../DatasetInformation/DatasetInformation.test.ts           | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/client/src/components/DatasetInformation/DatasetInformation.test.ts b/client/src/components/DatasetInformation/DatasetInformation.test.ts
index 74964e8034e7..a56fd7c70dea 100644
--- a/client/src/components/DatasetInformation/DatasetInformation.test.ts
+++ b/client/src/components/DatasetInformation/DatasetInformation.test.ts
@@ -73,6 +73,8 @@ describe("DatasetInformation/DatasetInformation", () => {
 
         // should contain 11 rows
         expect(rows.length).toBe(11);
+
+        await flushPromises();
     });
 
     it("file size should be formatted", async () => {
@@ -88,6 +90,8 @@ describe("DatasetInformation/DatasetInformation", () => {
         const formattedDate = format(parsedDate, "eeee MMM do H:mm:ss yyyy zz");
 
         expect(date).toBe(formattedDate);
+
+        await flushPromises();
     });
 
     it("Table should render data accordingly", async () => {
@@ -108,5 +112,7 @@ describe("DatasetInformation/DatasetInformation", () => {
                 expect(renderedText).toBe(datasetResponse[entry.backend_key].toString());
             }
         });
+
+        await flushPromises();
     });
 });

From a2dd47b31111bdc16189f4360722f1722c5c8d96 Mon Sep 17 00:00:00 2001
From: John Chilton <jmchilton@gmail.com>
Date: Fri, 22 Nov 2024 11:19:09 -0500
Subject: [PATCH 13/17] A fix and some expected log suppression for
 FilesDialog.test.ts.

---
 client/src/components/FilesDialog/FilesDialog.test.ts | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/client/src/components/FilesDialog/FilesDialog.test.ts b/client/src/components/FilesDialog/FilesDialog.test.ts
index 54cd7dcddf8f..60de0223dc1e 100644
--- a/client/src/components/FilesDialog/FilesDialog.test.ts
+++ b/client/src/components/FilesDialog/FilesDialog.test.ts
@@ -1,7 +1,7 @@
 import { createTestingPinia } from "@pinia/testing";
 import { mount, type Wrapper } from "@vue/test-utils";
 import flushPromises from "flush-promises";
-import { getLocalVue } from "tests/jest/helpers";
+import { getLocalVue, suppressDebugConsole } from "tests/jest/helpers";
 
 import { useServerMock } from "@/api/client/__mocks__";
 import { SELECTION_STATES, type SelectionItem, type SelectionState } from "@/components/SelectionDialog/selectionTypes";
@@ -73,6 +73,7 @@ const mockedOkApiRoutesMap = new Map<string, RemoteFilesList>([
         paramsToKey({ target: "gxfiles://pdb-gzip/directory1/subdirectory1", recursive: "false" }),
         subsubdirectoryResponse,
     ],
+    [paramsToKey({ target: "gxftp://", recursive: "false" }), pdbResponse],
 ]);
 
 const mockedErrorApiRoutesMap = new Map<string, RemoteFilesList>([
@@ -231,6 +232,8 @@ describe("FilesDialog, file mode", () => {
     it("should show loading error and can return back when there is an error", async () => {
         utils.expectNoErrorMessage();
 
+        suppressDebugConsole(); // expecting error message.
+
         // open directory with error
         await utils.openDirectoryById("empty-dir");
         utils.expectErrorMessage();
@@ -274,6 +277,8 @@ describe("FilesDialog, directory mode", () => {
     it("should show loading error and can return back when there is an error", async () => {
         utils.expectNoErrorMessage();
 
+        suppressDebugConsole(); // expecting error message.
+
         // open directory with error
         await utils.openDirectoryById("empty-dir");
         utils.expectErrorMessage();

From bf69131219f56ac908deb33ad02a1b8e1c5683d7 Mon Sep 17 00:00:00 2001
From: John Chilton <jmchilton@gmail.com>
Date: Fri, 22 Nov 2024 11:30:29 -0500
Subject: [PATCH 14/17] Remove stray log in RDMDestinationSelector.test.ts

---
 client/src/components/Common/RDMDestinationSelector.test.ts | 2 --
 1 file changed, 2 deletions(-)

diff --git a/client/src/components/Common/RDMDestinationSelector.test.ts b/client/src/components/Common/RDMDestinationSelector.test.ts
index 299e6a6498b0..2dca8e9c758b 100644
--- a/client/src/components/Common/RDMDestinationSelector.test.ts
+++ b/client/src/components/Common/RDMDestinationSelector.test.ts
@@ -70,8 +70,6 @@ describe("RDMDestinationSelector", () => {
 
             const emitted = wrapper.emitted("onRecordSelected");
 
-            console.log("EMITTED", emitted);
-
             expect(emitted).toBeTruthy();
             expect(emitted?.at(0)[0]).toEqual(FAKE_ENTRY.uri);
         });

From 92257aa2118cd52e4ac01152d69afb3d5238dfc5 Mon Sep 17 00:00:00 2001
From: John Chilton <jmchilton@gmail.com>
Date: Fri, 22 Nov 2024 11:30:55 -0500
Subject: [PATCH 15/17] Suppress expected error messages during test in sts
 monitor test.

---
 client/src/composables/shortTermStorageMonitor.test.ts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/client/src/composables/shortTermStorageMonitor.test.ts b/client/src/composables/shortTermStorageMonitor.test.ts
index 2dc3974c0668..8cdf1fb8b0ba 100644
--- a/client/src/composables/shortTermStorageMonitor.test.ts
+++ b/client/src/composables/shortTermStorageMonitor.test.ts
@@ -1,4 +1,5 @@
 import flushPromises from "flush-promises";
+import { suppressDebugConsole } from "tests/jest/helpers";
 
 import { useServerMock } from "@/api/client/__mocks__";
 import { useShortTermStorageMonitor } from "@/composables/shortTermStorageMonitor";
@@ -52,6 +53,8 @@ describe("useShortTermStorageMonitor", () => {
     });
 
     it("should indicate the task status request failed when the request failed", async () => {
+        suppressDebugConsole(); // expected API failure
+
         const { waitForTask, requestHasFailed, isRunning, isCompleted, taskStatus } = useShortTermStorageMonitor();
 
         expect(requestHasFailed.value).toBe(false);
@@ -90,6 +93,8 @@ describe("useShortTermStorageMonitor", () => {
         });
 
         it("should indicate is final state when the task has failed", async () => {
+            suppressDebugConsole(); // expected API failure
+
             const { waitForTask, isFinalState, isRunning, isCompleted, hasFailed, taskStatus } =
                 useShortTermStorageMonitor();
 

From 21b8b9e41adbe00d642f594eedbd8b82e171438f Mon Sep 17 00:00:00 2001
From: John Chilton <jmchilton@gmail.com>
Date: Fri, 22 Nov 2024 12:16:58 -0500
Subject: [PATCH 16/17] Add used mock in FilterMenu.test.ts - these are hard to
 spot.

---
 .../src/components/Common/FilterMenu.test.ts  | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/client/src/components/Common/FilterMenu.test.ts b/client/src/components/Common/FilterMenu.test.ts
index b9ba3db65b3b..b0c2093a395a 100644
--- a/client/src/components/Common/FilterMenu.test.ts
+++ b/client/src/components/Common/FilterMenu.test.ts
@@ -2,6 +2,7 @@ import { createTestingPinia } from "@pinia/testing";
 import { getLocalVue } from "@tests/jest/helpers";
 import { mount, type Wrapper } from "@vue/test-utils";
 
+import { useServerMock } from "@/api/client/__mocks__";
 import { HistoryFilters } from "@/components/History/HistoryFilters";
 import { setupSelectableMock } from "@/components/ObjectStore/mockServices";
 import { WorkflowFilters } from "@/components/Workflow/List/WorkflowFilters";
@@ -9,6 +10,8 @@ import Filtering, { compare, contains, equals, toBool, toDate } from "@/utils/fi
 
 import FilterMenu from "./FilterMenu.vue";
 
+const { server, http } = useServerMock();
+
 setupSelectableMock();
 
 const localVue = getLocalVue();
@@ -72,6 +75,22 @@ const TestFilters = new Filtering(validTestFilters, undefined);
 describe("FilterMenu", () => {
     let wrapper: Wrapper<Vue>;
 
+    beforeEach(() => {
+        server.use(
+            http.get("/api/users/{user_id}/usage", ({ response }) => {
+                return response(200).json([
+                    {
+                        quota: null,
+                        quota_bytes: null,
+                        quota_percent: null,
+                        quota_source_label: null,
+                        total_disk_usage: 4,
+                    },
+                ]);
+            })
+        );
+    });
+
     function setUpWrapper(name: string, placeholder: string, filterClass: Filtering<unknown>) {
         wrapper = mount(FilterMenu as object, {
             propsData: {

From 47ce2db3eb279fb1abdb7fcf56891c3d3e54e57e Mon Sep 17 00:00:00 2001
From: John Chilton <jmchilton@gmail.com>
Date: Fri, 22 Nov 2024 11:41:11 -0500
Subject: [PATCH 17/17] Fixup server mocking in NotificationForm.test.ts.

The previous mock was not actually preventing that initial fetch against the API to get an openapi schema.
---
 .../admin/Notifications/NotificationForm.test.ts          | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/client/src/components/admin/Notifications/NotificationForm.test.ts b/client/src/components/admin/Notifications/NotificationForm.test.ts
index 3f27b6d584e4..39240583af98 100644
--- a/client/src/components/admin/Notifications/NotificationForm.test.ts
+++ b/client/src/components/admin/Notifications/NotificationForm.test.ts
@@ -5,9 +5,13 @@ import flushPromises from "flush-promises";
 import { setActivePinia } from "pinia";
 import type Vue from "vue";
 
+import { useServerMock } from "@/api/client/__mocks__";
+
 import NotificationForm from "./NotificationForm.vue";
 
-jest.mock("@/api/schema");
+// Even though we don't use the API endpoints, this seems to prevent failure fetching
+// openapi during jest testing.
+useServerMock();
 
 const SUBMIT_BUTTON_SELECTOR = "#notification-submit";
 
@@ -46,5 +50,7 @@ describe("NotificationForm.vue", () => {
         const { wrapper } = await mountNotificationForm();
 
         expectSubmitButton(wrapper, false);
+
+        await flushPromises();
     });
 });