-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Picard update v.3.1.0 #5348
Picard update v.3.1.0 #5348
Conversation
b059603
to
3b59324
Compare
|
https://github.com/bioconda/bioconda-recipes/blob/master/recipes/picard/meta.yaml#L21 I hope that helps the solver and fixes 4 of our 5 problems. The 5th problem is a simsize of BAM files, you should not use simsize here, just diff.
|
||
## HISTOGRAM java.lang.Integer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That file does not look like a .tab anymore. Or it looks like 2 files in one. Is that expected?
16568 2.915862 3.835741 2 2 0 0 0 0.000041 0.008069 0 0.00811 0.684633 0.240464 0.055831 0.02541 0.010985 0 0 0 0 0 0 0 0 0 0.544024 3 | ||
## METRICS CLASS picard.analysis.WgsMetrics | ||
GENOME_TERRITORY MEAN_COVERAGE SD_COVERAGE MEDIAN_COVERAGE MAD_COVERAGE PCT_EXC_ADAPTER PCT_EXC_MAPQ PCT_EXC_DUPE PCT_EXC_UNPAIRED PCT_EXC_BASEQ PCT_EXC_OVERLAP PCT_EXC_CAPPED PCT_EXC_TOTAL PCT_1X PCT_5X PCT_10X PCT_15X PCT_20X PCT_25X PCT_30X PCT_40X PCT_50X PCT_60X PCT_70X PCT_80X PCT_90X PCT_100X FOLD_80_BASE_PENALTY FOLD_90_BASE_PENALTY FOLD_95_BASE_PENALTY HET_SNP_SENSITIVITY HET_SNP_Q | ||
16568 2.915862 3.835741 2 2 0 0 0 0 0.000041 0.008069 0 0.00811 0.684633 0.240464 0.055831 0.02541 0.010985 0 0 0 0 0 0 0 0 0 ? ? ? 0.544024 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are those ? expected?
sample-a tumor-a A T AAG 52 0 265 0 0 0 0 100 | ||
sample-a tumor-a A T AAT 240 0 1358 0 0 0 0 100 | ||
sample-a tumor-a A T CAA 101 0 573 0 0 0 0 100 | ||
picard_ARRG.bam picard_ARRG.bam A C AAA 58 0 857 0 0 0 0 100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sample-a tumar-a looked better in the last version as two times the file-name, do we know why this is happening?
sample-a tumor-a T A 100 ATA 100 ATN 100 NTA 100 NA | ||
sample-a tumor-a T C 100 GTA 24 CTN 29 NTG 30 NA | ||
sample-a tumor-a T G 100 ATA 100 ATN 100 NTA 100 NA | ||
picard_ARRG.bam picard_ARRG.bam A C 35 TAA 26 CAN 34 NAA 28 NA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
Lets try the 3.1 version. If it fails, feel free to revert it. |
Picard uses |
After checking that this doesn't change runtime and memory characteristics negatively (i think there's a good chance it would) this could be done in another PR. I don't think anyone's really using sam anymore, and if so, it's likely old and therefor often small data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @gallardoalba
Test didn't run again at all, not sure why |
This is the problem: |
We can igrnore this lint error. But this is also failing now:
|
:( still failing |
FOR CONTRIBUTOR: