-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add virAnnot tool #5482
Add virAnnot tool #5482
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marieBvr thanks a lot. I started with a first review. The test-data directory is really big. Can you please make sure that only stuff is included that is really needed?
Thanks a lot!
@@ -0,0 +1,216 @@ | |||
#!/usr/bin/env python3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you skip this tool and use https://usegalaxy.eu/root?tool_id=toolshed.g2.bx.psu.edu/repos/devteam/ncbi_blast_plus/blastxml_to_tabular/2.10.1+galaxy2 instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bgruening,
Thanks for your suggestion. I had look at this tool before implementing the virannot one.
Even if there is the annotation, it is missing the taxonomic info like Viruses;Riboviria;Orthornavirae;Kitrinoviricota;Alsuviricetes;Martellivirales;Bromoviridae;Ilarvirus;Blackberry chlorotic ringspot virus
.
In the near future I plan to only use the annotation for virAnnot, but that will be for the next version.
</param> | ||
</inputs> | ||
<outputs> | ||
<data format="xlsx" name="otu_table" label="${tool.name} on ${on_string}: otu_stats" from_work_dir="otu_output/otu_stats.xlsx" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xls and zip are not very good formats for further post-processing. Is there a useful output that the user should use for any further steps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The OTU module is the last step in the virannot suite. I don't see any other analyses, even in other pipelines.
</param> | ||
</inputs> | ||
<outputs> | ||
<data name="output" format="tabular" from_work_dir="rps_result.tab" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you like you can add column headers as metadata.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have an example ? I am not sure how to do it.
Co-authored-by: Björn Grüning <[email protected]>
Co-authored-by: Björn Grüning <[email protected]>
Co-authored-by: Björn Grüning <[email protected]>
Co-authored-by: Björn Grüning <[email protected]>
Co-authored-by: Björn Grüning <[email protected]>
Co-authored-by: Björn Grüning <[email protected]>
@marieBvr can we help here somehow? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marieBvr please check my changes and can you please check if all files in the test-data folder are required?
The rest looks great to me. Ready to be merged :)
Thanks @marieBvr! Great work, thanks for your patience with us. |
Attention: deployment failure! https://github.com/galaxyproject/tools-iuc/actions/runs/8144741884 |
Fixed the upload. Its now in the ToolShed. |
FOR CONTRIBUTOR: