Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add virAnnot tool #5482

Merged
merged 100 commits into from
Mar 4, 2024
Merged

Add virAnnot tool #5482

merged 100 commits into from
Mar 4, 2024

Conversation

marieBvr
Copy link
Contributor

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marieBvr thanks a lot. I started with a first review. The test-data directory is really big. Can you please make sure that only stuff is included that is really needed?

Thanks a lot!

tools/virAnnot/.shed.yml Show resolved Hide resolved
@@ -0,0 +1,216 @@
#!/usr/bin/env python3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@marieBvr marieBvr Sep 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bgruening,
Thanks for your suggestion. I had look at this tool before implementing the virannot one.
Even if there is the annotation, it is missing the taxonomic info like Viruses;Riboviria;Orthornavirae;Kitrinoviricota;Alsuviricetes;Martellivirales;Bromoviridae;Ilarvirus;Blackberry chlorotic ringspot virus.
In the near future I plan to only use the annotation for virAnnot, but that will be for the next version.

tools/virAnnot/macros.xml Outdated Show resolved Hide resolved
tools/virAnnot/virAnnot_blast2tsv.xml Outdated Show resolved Hide resolved
tools/virAnnot/virAnnot_blast2tsv.xml Outdated Show resolved Hide resolved
tools/virAnnot/virAnnot_otu.xml Outdated Show resolved Hide resolved
tools/virAnnot/virAnnot_otu.xml Outdated Show resolved Hide resolved
</param>
</inputs>
<outputs>
<data format="xlsx" name="otu_table" label="${tool.name} on ${on_string}: otu_stats" from_work_dir="otu_output/otu_stats.xlsx" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xls and zip are not very good formats for further post-processing. Is there a useful output that the user should use for any further steps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OTU module is the last step in the virannot suite. I don't see any other analyses, even in other pipelines.

tools/virAnnot/virAnnot_otu.xml Outdated Show resolved Hide resolved
</param>
</inputs>
<outputs>
<data name="output" format="tabular" from_work_dir="rps_result.tab" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you like you can add column headers as metadata.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have an example ? I am not sure how to do it.

tools/virAnnot/virannot.yml Outdated Show resolved Hide resolved
tools/virAnnot/virAnnot_tsv2krona.xml Outdated Show resolved Hide resolved
tools/virAnnot/virAnnot_tsv2krona.xml Outdated Show resolved Hide resolved
tools/virAnnot/virAnnot_tsv2krona.xml Outdated Show resolved Hide resolved
tools/virAnnot/virAnnot_tsv2krona.xml Outdated Show resolved Hide resolved
tools/virAnnot/virAnnot_otu.xml Outdated Show resolved Hide resolved
@bgruening
Copy link
Member

@marieBvr can we help here somehow?

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marieBvr please check my changes and can you please check if all files in the test-data folder are required?

The rest looks great to me. Ready to be merged :)

@marieBvr marieBvr mentioned this pull request Feb 29, 2024
@bgruening bgruening merged commit 3a3b40c into galaxyproject:main Mar 4, 2024
13 checks passed
@bgruening
Copy link
Member

Thanks @marieBvr! Great work, thanks for your patience with us.

@gxydevbot
Copy link
Collaborator

Attention: deployment failure!

https://github.com/galaxyproject/tools-iuc/actions/runs/8144741884

@bgruening
Copy link
Member

Fixed the upload. Its now in the ToolShed.

@bgruening bgruening mentioned this pull request Aug 12, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants