-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the new tool query_impc #5503
Conversation
@AndreaFurlani the tests are failing here. Do you need help figuring that out? Also please use macros to reduce the repeating elements in your wrapper. |
Hi @bgruening, yes thanks it would be helpful |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, much better. Now the test needs to be fixed :)
Hi @bgruening , I'm continuously get the following error during the tests: |
@AndreaFurlani your local Galaxy instance is too old. As we have added a more recent profile version here. However, on github the Galaxy version is newer that we use for testing so the error message here in the CI is different. You can download the tool error reports from this summary page: https://github.com/galaxyproject/tools-iuc/actions/runs/6338840242?pr=5503 Click on All tool tests results: If you do that you see three errors: One "parameter 'g_out': an invalid option ('txt') was selected (valid options: sym,mgi)" the other "Error: it was not possible to map the input." And the last "Output output: Test output file (test_output.tab) is missing. If you are using planemo, try adding --update_test_data to generate it." |
Hi @bgruening , now the tests are running correctly. |
Wonderful, I have created INFRAFRONTIERDIB#1 and added a few more comments there. |
ea5c896
to
358efe3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last comments. You can accept them in the GitHub interface.
I can not edit your files directly, you need to give us permission when you create the PR. If you do that I can do the small changes next time.
Thanks a lot @AndreaFurlani. Great contribution! If this gets merged it will be automatically deployed to the Galaxy ToolShed. If you would like to see this tool on the European Galaxy Server you can follow step 3 here: https://usegalaxy-eu.github.io/posts/2020/08/22/three-steps-to-galaxify-your-tool/ Thanks again! |
Thank you again @bgruening for all the help. We are going to follow step 3 then to get our tool on the European Galaxy Server. |
Hi @bgruening , regarding step 3 do I need to create a new branch or can I push on this one directly after creating the yaml file? Also it is not clear how should I call it. Thank you for the help |
Hi @AndreaFurlani. You need to create a fork of the repo, change the tools_iuc.yml file and create a PR. |
Sorry I made some mistakes with the old branch and I had to create a new one
FOR CONTRIBUTOR: