Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the new tool query_impc #5503

Merged
merged 30 commits into from
Oct 11, 2023
Merged

Conversation

AndreaFurlani
Copy link
Contributor

@AndreaFurlani AndreaFurlani commented Sep 26, 2023

Sorry I made some mistakes with the old branch and I had to create a new one

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

@bgruening
Copy link
Member

@AndreaFurlani the tests are failing here. Do you need help figuring that out? Also please use macros to reduce the repeating elements in your wrapper.

@AndreaFurlani
Copy link
Contributor Author

@AndreaFurlani the tests are failing here. Do you need help figuring that out? Also please use macros to reduce the repeating elements in your wrapper.

Hi @bgruening, yes thanks it would be helpful

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, much better. Now the test needs to be fixed :)

@AndreaFurlani
Copy link
Contributor Author

Hi @bgruening , I'm continuously get the following error during the tests:

Error_message.txt

@bgruening
Copy link
Member

@AndreaFurlani your local Galaxy instance is too old. As we have added a more recent profile version here.

However, on github the Galaxy version is newer that we use for testing so the error message here in the CI is different.

You can download the tool error reports from this summary page: https://github.com/galaxyproject/tools-iuc/actions/runs/6338840242?pr=5503

Click on All tool tests results:

grafik

If you do that you see three errors:

One "parameter 'g_out': an invalid option ('txt') was selected (valid options: sym,mgi)"

the other "Error: it was not possible to map the input."

And the last "Output output: Test output file (test_output.tab) is missing. If you are using planemo, try adding --update_test_data to generate it."

@AndreaFurlani
Copy link
Contributor Author

AndreaFurlani commented Oct 4, 2023

Hi @bgruening , now the tests are running correctly.
I noticed that there is still a check that is failing but I cannot get any error/log for that one. Does it need an input from our side?
Thank you for your advice

@AndreaFurlani AndreaFurlani changed the title I added the new tool query_impc Added the new tool query_impc Oct 4, 2023
@bgruening bgruening closed this Oct 7, 2023
@bgruening bgruening reopened this Oct 7, 2023
@bgruening
Copy link
Member

Wonderful, I have created INFRAFRONTIERDIB#1 and added a few more comments there.

@bgruening
Copy link
Member

2 errors are:

image

test 3 and 5.

and test 4 is:

image

@AndreaFurlani
Copy link
Contributor Author

2 errors are:

image

test 3 and 5.

and test 4 is:

image

I saw the reports, but still I don't get it why the tests are failing. Inputs are correct since by removing the conditionals they all succeed

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last comments. You can accept them in the GitHub interface.

I can not edit your files directly, you need to give us permission when you create the PR. If you do that I can do the small changes next time.

tools/query_impc/impc_tool.json Outdated Show resolved Hide resolved
tools/query_impc/impc_tool.xml Outdated Show resolved Hide resolved
tools/query_impc/impc_tool.xml Outdated Show resolved Hide resolved
@bgruening bgruening enabled auto-merge (squash) October 11, 2023 14:11
@bgruening
Copy link
Member

Thanks a lot @AndreaFurlani. Great contribution!

If this gets merged it will be automatically deployed to the Galaxy ToolShed. If you would like to see this tool on the European Galaxy Server you can follow step 3 here: https://usegalaxy-eu.github.io/posts/2020/08/22/three-steps-to-galaxify-your-tool/

Thanks again!

@bgruening bgruening merged commit 991881b into galaxyproject:main Oct 11, 2023
10 checks passed
@AndreaFurlani
Copy link
Contributor Author

Thanks a lot @AndreaFurlani. Great contribution!

If this gets merged it will be automatically deployed to the Galaxy ToolShed. If you would like to see this tool on the European Galaxy Server you can follow step 3 here: https://usegalaxy-eu.github.io/posts/2020/08/22/three-steps-to-galaxify-your-tool/

Thanks again!

Thank you again @bgruening for all the help. We are going to follow step 3 then to get our tool on the European Galaxy Server.

@AndreaFurlani
Copy link
Contributor Author

Thanks a lot @AndreaFurlani. Great contribution!

If this gets merged it will be automatically deployed to the Galaxy ToolShed. If you would like to see this tool on the European Galaxy Server you can follow step 3 here: https://usegalaxy-eu.github.io/posts/2020/08/22/three-steps-to-galaxify-your-tool/

Thanks again!

Hi @bgruening , regarding step 3 do I need to create a new branch or can I push on this one directly after creating the yaml file? Also it is not clear how should I call it. Thank you for the help

@bgruening
Copy link
Member

Hi @AndreaFurlani. You need to create a fork of the repo, change the tools_iuc.yml file and create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants