Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seqkit sort to existing seqkit suite #5909

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

TomHarrop
Copy link
Contributor

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

@bgruening
Copy link
Member

I added some tiny changes. Does this still looks good to you @TomHarrop?

The boolean and the select do contain the commanline part in their variable, so we can use them without a check.

@TomHarrop
Copy link
Contributor Author

Looks good, it failed for me locally when I did that but it passes here so I’m fine with it. Thanks @bgruening

@bgruening bgruening merged commit d3d2bb5 into galaxyproject:main Mar 26, 2024
14 checks passed
@TomHarrop TomHarrop deleted the seqkit_sort branch March 26, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants