Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding gem_tools #6598

Merged
merged 16 commits into from
Dec 13, 2024
Merged

adding gem_tools #6598

merged 16 commits into from
Dec 13, 2024

Conversation

emikar
Copy link
Contributor

@emikar emikar commented Dec 1, 2024

Adding a suite of tools for interacting with and analyzing genome-scale metabolic models (GEMs). These modules are primarily based on the cobrapy package, with which I (the contributor) am not affiliated.

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

Adding a suite of tools for interacting with and analyzing genome-scale metabolic models (GEMs). These modules are primarily based on the cobrapy package
tools/gem_tools/gem_check_memote.xml Outdated Show resolved Hide resolved
tools/gem_tools/.shed.yml Outdated Show resolved Hide resolved
tools/gem_tools/.shed.yml Show resolved Hide resolved
tools/gem_tools/gem_check_memote.xml Outdated Show resolved Hide resolved
tools/gem_tools/gem_check_memote.xml Outdated Show resolved Hide resolved
tools/gem_tools/gem_check_memote.xml Outdated Show resolved Hide resolved
tools/gem_tools/gem_extract_exchange.xml Outdated Show resolved Hide resolved
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you removed your .shed.yml file?

tools/gem_tools/.shed.yml Outdated Show resolved Hide resolved
tools/gem_tools/.shed.yml Outdated Show resolved Hide resolved
@emikar
Copy link
Contributor Author

emikar commented Dec 3, 2024

Very curious. The errors all indicate that the cobra module is missing, but when searching the conda channels suggested in the galaxyproject conda FAQ to be standard for Galaxy, it looks like cobra should be readily available. Am I overlooking something?

$ conda search cobra -c iuc -c conda-forge -c bioconda
Loading channels: done
# Name                       Version           Build  Channel             
cobra                        0.4.0b6          py27_0  bioconda            
cobra                        0.4.0b6          py34_0  bioconda            
cobra                        0.4.0b6          py35_0  bioconda            
cobra                          0.4.0          py27_0  bioconda            
cobra                          0.4.0          py27_1  bioconda            
cobra                          0.4.0          py34_0  bioconda            
cobra                          0.4.0          py35_0  bioconda            
cobra                          0.4.0          py35_1  bioconda            
cobra                          0.4.0          py36_0  bioconda            
cobra                          0.4.0          py36_1  bioconda            
cobra                         0.10.1          py27_0  bioconda            
cobra                         0.10.1          py35_0  bioconda            
cobra                         0.10.1          py36_0  bioconda            
cobra                         0.10.1            py_1  bioconda            
cobra                         0.15.4            py_0  bioconda            
cobra                         0.16.0            py_0  bioconda            
cobra                         0.17.0            py_0  bioconda            
cobra                         0.17.1            py_0  bioconda            
cobra                         0.18.1    pyh864c0ab_1  bioconda            
cobra                         0.18.1    pyh9f0ad1d_0  bioconda            
cobra                         0.19.0    pyh864c0ab_0  bioconda            
cobra                         0.20.0    pyh3252c3a_0  bioconda            
cobra                         0.21.0    pyh3252c3a_0  bioconda            
cobra                         0.21.0    pyh5e36f6f_1  bioconda            
cobra                         0.21.0    pyhd8ed1ab_0  conda-forge         
cobra                         0.22.0    pyhd8ed1ab_0  conda-forge         
cobra                         0.22.1    pyhd8ed1ab_0  conda-forge         
cobra                         0.22.1    pyhd8ed1ab_1  conda-forge         
cobra                         0.23.0    pyhd8ed1ab_0  conda-forge         
cobra                         0.24.0    pyhd8ed1ab_0  conda-forge         
cobra                         0.25.0    pyhd8ed1ab_1  conda-forge         
cobra                         0.26.0    pyhd8ed1ab_0  conda-forge         
cobra                         0.26.2    pyhd8ed1ab_0  conda-forge         
cobra                         0.26.3    pyhd8ed1ab_0  conda-forge         
cobra                         0.27.0    pyhd8ed1ab_0  conda-forge         
cobra                         0.28.0    pyhd8ed1ab_0  conda-forge         
cobra                         0.29.0    pyhd8ed1ab_0  conda-forge         
cobra                         0.29.1    pyhd8ed1ab_0  conda-forge         

tools/gem_tools/gem_check_memote.py Outdated Show resolved Hide resolved
tools/gem_tools/gem_check_memote.xml Outdated Show resolved Hide resolved
tools/gem_tools/gem_escher_visualization.xml Outdated Show resolved Hide resolved
tools/gem_tools/gem_escher_visualization.xml Outdated Show resolved Hide resolved
tools/gem_tools/gem_escher_visualization.xml Outdated Show resolved Hide resolved
tools/gem_tools/gem_flux_variability_analysis.xml Outdated Show resolved Hide resolved
tools/gem_tools/gem_knockout.xml Outdated Show resolved Hide resolved
@emikar
Copy link
Contributor Author

emikar commented Dec 8, 2024

Thanks for the valuable feedback on formatting! I think it's much easier to read now, even for myself, and probably a lot easier to maintain!

The core issue remains however, with the automatic tests failing. I don't have any such issues running the tests on my own machine using planemo test (see attached image). Are there any particular settings I need to run planemo test with to reproduce the particular merge test running here? Any help would be greatly appreciated :)

image

@bgruening
Copy link
Member

I restarted the CI and its green now :)

tools/gem_tools/gem_escher_visualization.xml Outdated Show resolved Hide resolved
tools/gem_tools/gem_escher_visualization.xml Outdated Show resolved Hide resolved
tools/gem_tools/gem_escher_visualization.xml Outdated Show resolved Hide resolved
tools/gem_tools/gem_escher_visualization.xml Outdated Show resolved Hide resolved
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emikar thanks a lot. Sorry for torturing you so long.

@bgruening bgruening merged commit 3f7bec1 into galaxyproject:main Dec 13, 2024
14 checks passed
@emikar
Copy link
Contributor Author

emikar commented Dec 14, 2024

@emikar thanks a lot. Sorry for torturing you so long.

Haha, not at all! There was some excellent feedback, and I definitely learned a trick or three. Thanks for the patience! :)

@emikar emikar deleted the gem_tools branch December 14, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants