Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace long-term IDs by default with short-form IDs? #50

Open
bgruening opened this issue Nov 6, 2022 · 1 comment
Open

replace long-term IDs by default with short-form IDs? #50

bgruening opened this issue Nov 6, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@bgruening
Copy link
Member

(not sure if this should be better discussed at the https://github.com/galaxyproject/tpv-shared-database repo)

Is there any reason we use the long-form IDs by default and need to add the * bits?

I think https://github.com/galaxyproject/tpv-shared-database/blob/main/tools.yml#L35 makes it rather hard for contributors to add new tools if they only know the short ID. In addition, the long ID increases the chance of hard-to-spot errors.

Is there any reason we use the long IDs by default? And why do we need to add the *, can this not be done by TPV?

In the example:

toolshed.g2.bx.psu.edu/repos/bgruening/deeptools/deeptools_bamCompare/.*:

Can we use by default deeptools_bamCompare:?
If people want to specify versions and be very strict they could use toolshed.g2.bx.psu.edu/repos/bgruening/deeptools/deeptools_bamCompare/3.2.1+galaxy1:

Thoughts?

@nuwang
Copy link
Member

nuwang commented Nov 14, 2022

The tool id is currently matched as a regex, hence the wildcard. The idea was to provide a lot of flexibility in matching an arbitrary tool. In addition, I have some vague recollection of some other complication, but looking at the code now, I'm not sure what it might be and what you propose sounds doable. Also, agree that it would make the base case less complicated, so it's probably worthwhile taking another shot at this.

@nuwang nuwang added the enhancement New feature or request label Nov 18, 2022
@nuwang nuwang closed this as completed Nov 21, 2022
@nuwang nuwang reopened this Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants