Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Screens/Article bugfix #113

Open
wants to merge 2 commits into
base: examples
Choose a base branch
from
Open

Screens/Article bugfix #113

wants to merge 2 commits into from

Conversation

shubhamkakkar
Copy link
Contributor

Resolved !!!

@palingheorghe
Copy link
Collaborator

palingheorghe commented Aug 28, 2019 •
edited
Loading

Please remove the .idea files, the PR is good but those files shouldn't be in here.

I've noticed the .idea folder quite everywhere in your PRs. Googled it up a bit and I think it has something to do with the IDE you're using. For future PRs add that folder to the .gitignore file so it won't be unnecessary pushed.

Thanks! ❤️

@shubhamkakkar
Copy link
Contributor Author

Buddy!! .idea is removed !!

@shubhamkakkar
Copy link
Contributor Author

Yeah, I too think its IDE, I am using webstorm, so it could be the reason!!

@palingheorghe palingheorghe mentioned this pull request Sep 9, 2019
Closed
@palingheorghe palingheorghe changed the title issue #102 Screens/Article bugfix Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palingheorghe palingheorghe palingheorghe approved these changes

Assignees
No one assigned
Labels
Status: Accepted Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shubhamkakkar @palingheorghe