Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed IsNonSeparatingCycle #296

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

MeikeWeiss
Copy link
Collaborator

I changed IsNonSeparatingCycle such that it shoud work now also for graphs that are not cubic.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.36%. Comparing base (8264009) to head (25858f4).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #296   +/-   ##
=======================================
  Coverage   76.36%   76.36%           
=======================================
  Files          63       63           
  Lines       16399    16398    -1     
=======================================
  Hits        12523    12523           
+ Misses       3876     3875    -1     
Files with missing lines Coverage Δ
gap/PolygonalComplexes/graphs.gi 93.79% <100.00%> (+0.15%) ⬆️

@FlynnFehre
Copy link
Contributor

I did some checks and everything worked fine. Looks good!

Copy link
Collaborator

@ReymondAkpanya ReymondAkpanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good :)

@ReymondAkpanya ReymondAkpanya merged commit 1548ac4 into gap-packages:master Oct 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants