Change title colour for dark mode #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
reviewed
Aug 30, 2024
_sass/custom/custom.scss
Outdated
| #text-only-logo { | ||
| font-weight: bold; | ||
| font-size: 45px; | ||
| color: $gap-light-blue; |
There was a problem hiding this comment.
Did you perhaps mean this?
Suggested change
| color: $gap-light-blue; | |
| color: $gap-blue; |
|
I"ve updated it to actually work by adding |
|
Looks great. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, dark mode has a rather dark blue against the dark grey, which doesn't look great. This PR would use our "GAP light" colour, assuming I haven't made any mistakes.
(I'm having trouble testing locally)