Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

Gardenctl update enhancement. #482

Open
tedteng opened this issue Dec 3, 2020 · 7 comments · May be fixed by #484
Open

Gardenctl update enhancement. #482

tedteng opened this issue Dec 3, 2020 · 7 comments · May be fixed by #484
Assignees
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage)

Comments

@tedteng
Copy link
Contributor

tedteng commented Dec 3, 2020

Describe the bug
The update feature only displays the information currently

gardenctl update

New version "v0.24.0" of Gardenctl is available at https://github.com/gardener/gardenctl/releases/latest
Please get latest version from above URL and see https://github.com/gardener/gardenctl#installation for how to upgrade

I like to install the latest version or previous version with a version number in local when using the update feature

@tedteng tedteng self-assigned this Dec 3, 2020
@tedteng tedteng added the kind/enhancement Enhancement, improvement, extension label Dec 3, 2020
@neo-liang-sap
Copy link
Contributor

neo-liang-sap commented Dec 3, 2020

  • could you please remove Describe the bug from description? it's not a bug, when you open new issue other than bug please choose "open blank issue"
  • from user perspective i don't see any reason why they should revert to an old version, we should always encourage user to use latest version of gardenctl. If you'd like to revert back to some previous version due to development purpose, then it's should be a development utilization tool, not released to customer.

By literal meaning, update means to a higher version, we should not include rollback / revert function unless we are in a production deployment scenario, obviously gardenctl is not for this kind of scenario.

@neo-liang-sap
Copy link
Contributor

/invite @dansible , what do you think?

@gardener-robot
Copy link

@neo-liang-sap Command /invite is not allowed for issue but only for pullrequest.

@tedteng
Copy link
Contributor Author

tedteng commented Dec 3, 2020

about the update feature (gardenctl update), as I mentioned above the current process needs manual installation. which is my main purpose, regarding the older version installation is not the main pain point for me now. just an extra feature. I am not too worry about older version installation part, I am fine without this part. besides, the command of an older version installation maybe like gardenctl install old version something like. I think you can get the idea is not literal mean you need gardenctl update old version. don't worry about it. I will more force on the update automation part as that is my mean pain point now.

gardenctl update

New version "v0.24.0" of Gardenctl is available at https://github.com/gardener/gardenctl/releases/latest
Please get latest version from above URL and see https://github.com/gardener/gardenctl#installation for how to upgrade

@tedteng
Copy link
Contributor Author

tedteng commented Dec 4, 2020

image
image

@tedteng tedteng linked a pull request Dec 4, 2020 that will close this issue
@andrei-panov
Copy link
Contributor

add --make-backup flag? Then for the previous version, you can run prev_gardenctl ?

@tedteng
Copy link
Contributor Author

tedteng commented Dec 7, 2020

It could be, but I haven't decided whether need to handle the previous version yet or how to handle it in the proper ways. but I think the auto-upgrade is more useful now.

@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Sep 22, 2021
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants