Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added HSTS headers in healthz endpoint response #855

Closed
wants to merge 1 commit into from
Closed

Added HSTS headers in healthz endpoint response #855

wants to merge 1 commit into from

Conversation

sssash18
Copy link
Contributor

@sssash18 sssash18 commented Oct 13, 2023 •
edited by aaronfern
Loading

What this PR does / why we need it:
Adds HSTS headers in the healthz endpoint
Which issue(s) this PR fixes:
Fixes #825

Special notes for your reviewer:

Release note:

NONE

@sssash18 sssash18 requested a review from a team as a code owner October 13, 2023 06:04
@gardener-robot
Copy link

@sssash18 Thank you for your contribution.

@CLAassistant
Copy link

CLAassistant commented Oct 13, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Oct 13, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 13, 2023
@sssash18 sssash18 requested a review from rishabh-11 October 13, 2023 06:05
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 13, 2023
@sssash18 sssash18 changed the title Added HSTS headers in healthz endpoint Added HSTS headers in healthz endpoint response Oct 13, 2023
@gardener-robot
Copy link

@rishabh-11 You have pull request review open invite, please check

@rishabh-11
Copy link
Contributor

/hold
Not as simple as it seems. Need to discuss more on this.

@gardener-robot gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Oct 16, 2023
@sssash18 sssash18 closed this Oct 17, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabh-11 rishabh-11 Awaiting requested review from rishabh-11

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add HSTS header to healthz endpoint response
5 participants
@sssash18 @gardener-robot @CLAassistant @rishabh-11 @gardener-robot-ci-2