This commit considers $CI to generate shorter log console output
#101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Fixes: #36 Signed-off-by: Tobias Wolf <[email protected]>
NotTheEvilOne
force-pushed
the
prs/support-shorter-logs-for-CI
branch
from
aeab082 to
fe171c6
Compare
nkraetzschmar
requested changes
Dec 20, 2024
| @@ -1,6 +1,6 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| set -eufo pipefail | |||
| set -efo pipefail | |||
There was a problem hiding this comment.
removing the set -u is not great (might result in uncaught errors down the line).... instead of relying on this, please do something like "${CI:-false}" to handle cases where $CI is not set.
| @@ -97,6 +97,7 @@ if [ "$resolve_cname" = 1 ]; then | |||
| fi | |||
|
|
|||
| make_opts=( | |||
| CI="$CI" | |||
There was a problem hiding this comment.
Not sure if $CI is the most intuitive control var name.... maybe make it more explicit what this dose, along the lines of NO_PRINT_TIMESTAMPS or something 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To support short log console messages if executed in CI environments
$CIis considered nd if set totrueremoves date&time information.Which issue(s) this PR fixes:
Fixes #36