Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deduplicate flavours.yaml #9

Open
MrBatschner opened this issue Nov 21, 2022 · 1 comment
Open

deduplicate flavours.yaml #9

MrBatschner opened this issue Nov 21, 2022 · 1 comment
Assignees
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/stale Nobody worked on this for 6 months (will further age) needs/review Needs review needs/second-opinion Needs second review by someone else

Comments

@MrBatschner
Copy link
Member

What would you like to be added:

There is a flavours.yaml in gardenlinux/gardenlinux and another one in gardenlinux/glci. One of it (preferably the one in gardenlinux/gardenlinux) should have authority and the other one should be removed.

Why is this needed:

Potentially unnecessary duplication of code and other information across the Garden Linux source repository and the release pipeline repository make maintenance harder and introduces opportunity for error.

@MrBatschner MrBatschner added the kind/enhancement Enhancement, improvement, extension label Nov 21, 2022
@ccwienk
Copy link
Contributor

ccwienk commented Nov 28, 2022

done: 165b822

as of this change, flavours.yaml will either be lookup up in sibling directory (gardenlinux), or (as before) configurable via env-var.

I plan to:

  • re-implement publishing to work in single process / locally via CLI
  • re-implement pipeline in single job; pbly using concourse, so we can drop tekton (which we had to introduce due to technical reasons that no longer prevail)

@ccwienk ccwienk self-assigned this Nov 28, 2022
@ccwienk ccwienk added needs/review Needs review needs/second-opinion Needs second review by someone else labels Nov 30, 2022
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/stale Nobody worked on this for 6 months (will further age) needs/review Needs review needs/second-opinion Needs second review by someone else
Projects
None yet
Development

No branches or pull requests

3 participants