Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot transform import x, * as xs from "..." #102

Open
denizdogan opened this issue Jun 7, 2023 · 2 comments
Open

Cannot transform import x, * as xs from "..." #102

denizdogan opened this issue Jun 7, 2023 · 2 comments

Comments

@denizdogan
Copy link

It's not a big deal, but Denoify currently fails to detect/transform imports with the following structure:

import x, * as xs from "..."

This is easily fixed by doing:

import { default as x } from "..."
import * as xs from "..."

But I think it should be considered a bug anyway.

@garronej
Copy link
Owner

garronej commented Jun 7, 2023

Hi @denizdogan,

It's a bug indeed, or rather a syntax that I didn't know existed. Thanks for reporting.

Why do you deconstruct the default in your workaround?

import x from "..."; isn't properly transformed?

@denizdogan
Copy link
Author

@garronej Just an old habit I guess, your version works too :)

denizdogan added a commit to denizdogan/edgedb-js that referenced this issue Jun 8, 2023
denizdogan added a commit to denizdogan/edgedb-js that referenced this issue Jun 9, 2023
denizdogan added a commit to denizdogan/edgedb-js that referenced this issue Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants