Feature Request: not following redirects

[EtienneBruines]

Hi!

Sometimes, I'd want to be able to "not follow" redirects, such as http.StatusFound. A lot of my pages are behind a login, and checking whether or not the page works, by saying .expect(http.StatusOK) would be misleading; since the server returned a http.StatusFound instead, and now redirected the client to the login page.

I'm currently using this workaround, but it's doesn't really feel right:

        url := e.GET("/secure/").
            Expect().
            Status(http.StatusOK).
            Raw().Request.URL.RequestURI()
        assert.Equal(t, "/secure", url, "We are authenticated and trying to access /secure")

I'd love to be able to do something like:

e.GET("/secure").
    NoFollow().
    Expect().
    Status(http.StatusOK)

[EtienneBruines]

Nevermind, this can be done by changing the http.Client:

        Client: &http.Client{
            Transport: httpexpect.NewFastBinder(handler),
            CheckRedirect: func(req *http.Request, via []*http.Request) error {
                return http.ErrUseLastResponse
            },
            Jar: httpexpect.NewJar(),
        },

I followed this Stack Overflow question, but apparently, the answers were outdated.

Apologies for the fuss.

[gavv]

Thanks for sharing this. I've also seen that question. Actually, ErrUseLastResponse seems to be the best answer :)

[pas256]

I know this is old so apologies, but I do not see how to use the code @EtienneBruines posted within a test. How do I modify the underlying Client?

[EtienneBruines]

@pas256 It's been a while, so I have no idea.

But, looking at the source code of one of the tests:

https://github.com/gavv/httpexpect/blob/master/e2e_redirect_test.go#L58

func TestE2ERedirectBinderStandard(t *testing.T) {
	handler := createRedirectHandler()

	testRedirectHandler(WithConfig(Config{
		BaseURL:  "http://example.com",
		Reporter: NewAssertReporter(t),
		Client: &http.Client{
			Transport: NewBinder(handler),
		},
	}))
}

It seems like you can use WithConfig to set it. See also WithConfig

[gavv]

Yes, you can use WithConfig or WithClient:

• https://github.com/gavv/httpexpect#custom-config
• https://github.com/gavv/httpexpect#per-request-client-or-handler