diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 88a3b573..3bc481ba 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,6 +1,12 @@ name: Ubuntu CI -on: [push, pull_request] +on: + pull_request: + push: + branches: + - 'ign-cmake[0-9]' + - 'gz-cmake[0-9]' + - 'main' jobs: jammy-ci: @@ -8,7 +14,7 @@ jobs: name: Ubuntu Jammy CI steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Compile and test id: ci uses: gazebo-tooling/action-gz-ci@jammy diff --git a/.github/workflows/triage.yml b/.github/workflows/triage.yml index 2c94852d..2332244b 100644 --- a/.github/workflows/triage.yml +++ b/.github/workflows/triage.yml @@ -14,4 +14,3 @@ jobs: with: project-url: https://github.com/orgs/gazebosim/projects/7 github-token: ${{ secrets.TRIAGE_TOKEN }} - diff --git a/Changelog.md b/Changelog.md index 238f6990..540a8c3a 100644 --- a/Changelog.md +++ b/Changelog.md @@ -180,6 +180,11 @@ ## Gazebo CMake 2.x +### Gazebo CMake 2.17.1 (2023-08-31) + +1. FindIgnOgre*: fix LIBRARY_DIRS and PLUGINDIR resolution when using pkgconfig + * [Pull request #376](https://github.com/gazebosim/gz-cmake/pull/376) + ### Gazebo CMake 2.17.0 (2023-05-19) 1. Use CONFIG in gz_add_benchmark to avoid Windows collisions diff --git a/README.md b/README.md index 95741c1e..f92b84c2 100644 --- a/README.md +++ b/README.md @@ -7,9 +7,9 @@ Build | Status -- | -- -Ubuntu Focal | [![Build Status](https://build.osrfoundation.org/buildStatus/icon?job=ignition_cmake-ci-main-focal-amd64)](https://build.osrfoundation.org/job/ignition_cmake-ci-main-focal-amd64) -Homebrew | [![Build Status](https://build.osrfoundation.org/buildStatus/icon?job=ignition_cmake-ci-main-homebrew-amd64)](https://build.osrfoundation.org/job/ignition_cmake-ci-main-homebrew-amd64) -Windows | [![Build Status](https://build.osrfoundation.org/buildStatus/icon?job=ignition_cmake-ci-main-windows7-amd64)](https://build.osrfoundation.org/job/ignition_cmake-ci-main-windows7-amd64) +Ubuntu Jammy | [![Build Status](https://build.osrfoundation.org/buildStatus/icon?job=gz_cmake-ci-main-jammy-amd64)](https://build.osrfoundation.org/job/gz_cmake-ci-main-jammy-amd64) +Homebrew | [![Build Status](https://build.osrfoundation.org/buildStatus/icon?job=gz_cmake-ci-main-homebrew-amd64)](https://build.osrfoundation.org/job/gz_cmake-ci-main-homebrew-amd64) +Windows | [![Build Status](https://build.osrfoundation.org/buildStatus/icon?job=gz_cmake-main-win)](https://build.osrfoundation.org/job/gz_cmake-main-win) # Table of Contents diff --git a/cmake/GzFindPackage.cmake b/cmake/GzFindPackage.cmake index 1b1a74c6..93da8032 100644 --- a/cmake/GzFindPackage.cmake +++ b/cmake/GzFindPackage.cmake @@ -156,8 +156,8 @@ macro(gz_find_package PACKAGE_NAME_) # Define the expected arguments set(options REQUIRED PRIVATE EXACT QUIET CONFIG BUILD_ONLY PKGCONFIG_IGNORE) - set(oneValueArgs VERSION PRETTY PURPOSE EXTRA_ARGS PKGCONFIG PKGCONFIG_LIB PKGCONFIG_VER_COMPARISON) - set(multiValueArgs REQUIRED_BY PRIVATE_FOR COMPONENTS OPTIONAL_COMPONENTS) + set(oneValueArgs VERSION PRETTY PURPOSE PKGCONFIG PKGCONFIG_LIB PKGCONFIG_VER_COMPARISON) + set(multiValueArgs REQUIRED_BY PRIVATE_FOR COMPONENTS OPTIONAL_COMPONENTS EXTRA_ARGS) #------------------------------------ # Parse the arguments diff --git a/cmake/GzSetCompilerFlags.cmake b/cmake/GzSetCompilerFlags.cmake index 33dedf56..e2e42824 100644 --- a/cmake/GzSetCompilerFlags.cmake +++ b/cmake/GzSetCompilerFlags.cmake @@ -77,17 +77,7 @@ endmacro() # Configure settings for Unix # Internal to gz-cmake. macro(_gz_setup_unix) - - find_program(CMAKE_UNAME uname /bin /usr/bin /usr/local/bin ) - if(CMAKE_UNAME) - exec_program(${CMAKE_UNAME} ARGS -m OUTPUT_VARIABLE CMAKE_SYSTEM_PROCESSOR) - set(CMAKE_SYSTEM_PROCESSOR ${CMAKE_SYSTEM_PROCESSOR} CACHE INTERNAL - "processor type (i386 and x86_64)") - if(CMAKE_SYSTEM_PROCESSOR MATCHES "x86_64") - set(GZ_ADD_fPIC_TO_LIBRARIES true) - endif(CMAKE_SYSTEM_PROCESSOR MATCHES "x86_64") - endif(CMAKE_UNAME) - + # No custom setup for Unix systems endmacro() ################################################# diff --git a/cmake/GzUtils.cmake b/cmake/GzUtils.cmake index 2f71f357..cacdde16 100644 --- a/cmake/GzUtils.cmake +++ b/cmake/GzUtils.cmake @@ -214,12 +214,6 @@ macro(_gz_add_library_or_component) add_library(${lib_name} ${sources}) endif() - #------------------------------------ - # Add fPIC if we are supposed to - if(GZ_ADD_fPIC_TO_LIBRARIES AND NOT _gz_add_library_INTERFACE) - target_compile_options(${lib_name} PRIVATE -fPIC) - endif() - if(NOT _gz_add_library_INTERFACE) #------------------------------------ diff --git a/examples/core_child/CMakeLists.txt b/examples/core_child/CMakeLists.txt index 60393659..2b758e30 100644 --- a/examples/core_child/CMakeLists.txt +++ b/examples/core_child/CMakeLists.txt @@ -2,7 +2,7 @@ cmake_minimum_required(VERSION 3.22.1 FATAL_ERROR) project(gz-core_child VERSION 0.1.0) find_package(gz-cmake4 REQUIRED) gz_configure_project() -gz_find_package(gz-core_no_deps REQUIRED) +gz_find_package(gz-core_no_deps REQUIRED EXTRA_ARGS NAMES gz-core_no_deps) gz_configure_build(QUIT_IF_BUILD_ERRORS) gz_create_packages() gz_create_docs(TAGFILES "${GZ-CORE_NO_DEPS_DOXYGEN_TAGFILE} = ${GZ-CORE_NO_DEPS_API_URL}")