Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FindGzOGRE2.cmake does not work with upstream default cmake config #388

Closed
oysstu opened this issue Oct 5, 2023 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@oysstu
Copy link

oysstu commented Oct 5, 2023

Environment

  • OS Version: N/A
  • Source or binary build?
    Source gz-cmake3 3.4.1

Description

  • Expected behavior: Find installed OGRE2/Ogre-Next libraries with default upstream cmake config
  • Actual behavior: Does not find OGRE-Next without re-compiling with OGRE_USE_NEW_PROJECT_NAME=TRUE. This option has been added in master, but not released yet (default=FALSE until Ogre-Next >= 4.x)

The GZ_OGRE2_PROJECT_NAME variable permits changing the name of the upstream project between "OGRE2" and "Ogre-Next", but not "OGRE". I expect downstream packagers to transition to Ogre-Next before that, but it would be convenient to use GZ_OGRE2_PROJECT_NAME until then.

@oysstu oysstu added the bug Something isn't working label Oct 5, 2023
@oysstu
Copy link
Author

oysstu commented Oct 5, 2023

I'm just going to close this until I can follow it up better. For some reason, it's unable to accept the pkgconfig under "look for OGRE2 installed from source". It's searching with the correct PKG_CONFIG_PATH, so I'm not sure what could be wrong.

@oysstu oysstu closed this as completed Oct 5, 2023
@github-project-automation github-project-automation bot moved this from Inbox to Done in Core development Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

1 participant