Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz CMake, Python, Partial Source, and File Migrations : gz-msgs #269

Merged
merged 2 commits into from
Jul 13, 2022
Merged

ign -> gz CMake, Python, Partial Source, and File Migrations : gz-msgs #269

merged 2 commits into from
Jul 13, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon requested a review from caguero as a code owner July 12, 2022 18:15
@methylDragon methylDragon mentioned this pull request Jul 12, 2022
Closed
32 tasks
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 12, 2022
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

1 similar comment
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

@methylDragon methylDragon force-pushed the ci_matching_branch/file_and_source_migration branch from ff376e7 to f0f8265 Compare July 12, 2022 20:55
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

1 similar comment
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

@codecov
Copy link

codecov bot commented Jul 13, 2022 •
edited
Loading

Codecov Report

Merging #269 (8ae3e20) into main (7cf04fc) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 8ae3e20 differs from pull request most recent head fdd59dc. Consider uploading reports for the commit fdd59dc to get more accurate results

@@           Coverage Diff           @@
##             main     #269   +/-   ##
=======================================
  Coverage   14.53%   14.53%           
=======================================
  Files         200      200           
  Lines       12505    12505           
=======================================
  Hits         1817     1817           
  Misses      10688    10688
Impacted Files Coverage Δ
src/Generator.cc 92.53% <ø> (ø)
src/Utility.cc 82.28% <ø> (ø)
src/generator_main.cc 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cf04fc...fdd59dc. Read the comment docs.

@methylDragon methylDragon force-pushed the ci_matching_branch/file_and_source_migration branch from f0f8265 to 9fad3f8 Compare July 13, 2022 00:16
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jul 13, 2022
chapulina
chapulina approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 🟢 CI

@methylDragon
Migrate bazel file (#270)
5d83d9e 
Signed-off-by: methylDragon <[email protected]>
@methylDragon methylDragon force-pushed the ci_matching_branch/file_and_source_migration branch from 9fad3f8 to 253d013 Compare July 13, 2022 08:17
@methylDragon methylDragon force-pushed the ci_matching_branch/file_and_source_migration branch from 253d013 to fdd59dc Compare July 13, 2022 08:24
@methylDragon methylDragon merged commit e19d438 into main Jul 13, 2022
@methylDragon methylDragon deleted the ci_matching_branch/file_and_source_migration branch July 13, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@caguero caguero Awaiting requested review from caguero caguero is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina