🧑‍🌾 Error C2065: 'M_PI': undeclared identifier in AdvancedLiftDrag.cc(618,64)

[Crola1702]

Environment

• OS Version: Windows CI
• Source gz-sim build

Description

• Expected behavior: Build should pass
• Actual behavior: Build is failing because of an undeclared identifier

Steps to reproduce

1. Run a job in gz-sim7 or 8
2. See build fail

Output

Reference build: gz-sim8-win

Log output:

  gz-sim8-acoustic-comms-system.vcxproj -> C:\J\workspace\ign_gazebo-gz-8-win\ws\build\gz-sim8\bin\Release\gz-sim8-acoustic-comms-system.dll

  Building Custom Rule C:/J/workspace/ign_gazebo-gz-8-win/ws/gz-sim/src/systems/advanced_lift_drag/CMakeLists.txt

  AdvancedLiftDrag.cc

C:\J\workspace\ign_gazebo-gz-8-win\ws\gz-sim\src\systems\advanced_lift_drag\AdvancedLiftDrag.cc(618,64): error C2065: 'M_PI': undeclared identifier [C:\J\workspace\ign_gazebo-gz-8-win\ws\build\gz-sim8\src\systems\advanced_lift_drag\gz-sim8-advanced-lift-drag-system.vcxproj]

C:\J\workspace\ign_gazebo-gz-8-win\ws\gz-sim\src\systems\advanced_lift_drag\AdvancedLiftDrag.cc(674,46): error C2065: 'M_PI': undeclared identifier [C:\J\workspace\ign_gazebo-gz-8-win\ws\build\gz-sim8\src\systems\advanced_lift_drag\gz-sim8-advanced-lift-drag-system.vcxproj]

M_PI mentions: https://github.com/gazebosim/gz-sim/blob/gz-sim8/src/systems/advanced_lift_drag/AdvancedLiftDrag.cc#L618 and https://github.com/gazebosim/gz-sim/blob/gz-sim8/src/systems/advanced_lift_drag/AdvancedLiftDrag.cc#L674.

This is only failing in Windows

[scpeters]

it should be GZ_PI

[scpeters]

it should be GZ_PI

from https://github.com/gazebosim/gz-math/blob/6460f7c0a59833e2729157d246ee07806ff56126/include/gz/math/Helpers.hh#L43-L55