Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta] Condense nested namespaces #2276

Open
3 of 16 tasks
mjcarroll opened this issue Jan 4, 2024 · 0 comments
Open
3 of 16 tasks

[Meta] Condense nested namespaces #2276

mjcarroll opened this issue Jan 4, 2024 · 0 comments

Comments

@mjcarroll
Copy link
Contributor

mjcarroll commented Jan 4, 2024

Since we are using C++17, we can replace:

namespace gz {
namespace fuel_tools {

with

namespace gz::fuel_tools

This isn't a high priority change, as it is mostly cosmetic, but it would be nice to get on all of the harmonic branches and then ported forward to ionic.

For each repo, we should:

  • Collapse nested namespaces
  • Check that include guards are correct.
  • Remove using namespace from headers
  • (optionally) Remove using namespace from core library sources

I'm using this issue to track progress:

@mjcarroll mjcarroll changed the title [Meta]: Condense nested namespaces [Meta] Condense nested namespaces Jan 4, 2024
@azeey azeey moved this from Inbox to In progress in Core development Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

No branches or pull requests

1 participant