Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for automatically populating a model's linear velocity if a LinearVelocityCmd is applied to it #998

Open
adlarkin opened this issue Aug 26, 2021 · 0 comments
Labels
enhancement New feature or request help wanted We accept pull requests!

Comments

@adlarkin
Copy link
Contributor

Desired behavior

When a user applies a LinearVelocityCmd component to a model, the model's LinearVelocity component should be populated (if the LinearVelocity component exists). Currently, we have this behavior implemented for links, but not models. Links also have their WorldPose, AngularVelocity, LinearAcceleration and AngularAcceleration components auto-populated if they exist, so perhaps we could also populate these components for models.

Alternatives considered

N/A (new feature) - a temporary workaround for applying/reading linear velocities of models can be doing this on the model's canonical link.

Implementation suggestion

See #992 (comment)

Additional context

This missing functionality was discovered while addressing #966.

The code for populating pose/velocity/acceleration for links can be found here. It also looks like we also do something similar for sensors/collisions (the relevant code for sensors/collisions can be found here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted We accept pull requests!
Projects
None yet
Development

No branches or pull requests

1 participant