Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapping search: filter by annotation #605

Closed
nichtich opened this issue May 28, 2021 · 7 comments
Closed

Mapping search: filter by annotation #605

nichtich opened this issue May 28, 2021 · 7 comments
Labels
feature Additional functionality
Milestone

Comments

@nichtich
Copy link
Member

Support searching for annotated mappings. This is already supported by JSKOS server (annotatedFor and annotatedWith)

@nichtich nichtich added the feature Additional functionality label May 28, 2021
@nichtich nichtich added this to the 1.6.0 milestone Dec 10, 2021
@stefandesu
Copy link
Member

It would be nice to also have a filter whether the total rating of a mapping is positive or negative (see #666).

@stefandesu
Copy link
Member

This requires some changes in jskos-server (if we want the total rating) and I would also deal with #671 first, so I'm moving this to the next milestone.

@stefandesu
Copy link
Member

This is now pretty much done from my point of view and it works well locally as well as with the Dev Registry in Cocoda Dev. To work with the main registry, we need a release of JSKOS Server. I will do some more testing before closing this.

@stefandesu
Copy link
Member

@nichtich Currently we have all available options that JSKOS Server offers in the interface. That is:

  • any
  • none
  • assessed (-1/+1)
  • assessed (+1)
  • assessed (-1)
  • not assessed
  • confirmed
  • not confirmed

There was already some confusion because the filter is called "assessment", so the differentiation between "none" and "not assessed" was not clear. However, I would like to avoid too technical terms in the interface.

I'm personally not sure whether "any" is even needed. My suggestion would be to remove "any", and rename "none" to "neither assessed nor confirmed" and move it to the bottom of the list. What do you think?

@nichtich
Copy link
Member Author

nichtich commented Jul 5, 2022

I'm personally not sure whether "any" is even needed. My suggestion would be to remove "any", and rename "none" to "neither assessed nor confirmed" and move it to the bottom of the list. What do you think?

In general I agree but I am not sure about the position, how do you clear the filter?

@stefandesu
Copy link
Member

It works exactly like any of the other filters (mapping type, cardinality, concordance). I didn't change anything about how search filters work in general. So I'm not sure what you mean. (You clear the filter either by selecting "-" as an option or clicking the "Clear" button.)

Improvements to the search filters in general will come later in #671. This issue is only about this particular filter.

@nichtich
Copy link
Member Author

nichtich commented Jul 5, 2022

ok, implement as proposed without "any".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Additional functionality
Projects
None yet
Development

No branches or pull requests

2 participants