Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace component functionality, mixins, and possibly store with Composition API #689

Open
stefandesu opened this issue Jun 14, 2022 · 1 comment
Labels
cleanup code cleanup, refactoring, testing...
Milestone

Comments

@stefandesu
Copy link
Member

The Vue Composition API (plugin for Vue 2 which is already integrated into the project) makes reusing certain functionality very easy and easier to understand. If possible, I would like to move a lot of the current functionality in components, mixins, and the Vuex store to the Composition API. I think this would 1) reduce code duplication even further, 2) make the code easier to understand in many places, and 3) make future adjustments easier as well.

@stefandesu stefandesu added this to the 1.8.0 milestone Jun 14, 2022
@stefandesu
Copy link
Member Author

I've updated Vue.js to 2.7 which integrates the Composition API plugin. However, due to the upgrade, I noticed a message on the console:

[Vue warn]: Avoid using Array as root value for reactive() as it cannot be tracked in watch() or watchEffect(). Use ref() instead. This is a Vue-2-only limitation.

We're using arrays as root values for several things, including schemes and concordances. This also explains some issues I had with things not happening when schemes are updated. However, fixing this requires some more changes, so I'm noting this down here as another to-do item.

stefandesu added a commit that referenced this issue Jul 5, 2022
Requires using xyz.value instead of using it directly, but ensures proper reactivity. In theory, this could be reversed if we ever move to Vue.js 3 as it is a Vue-2-only limitation.
@nichtich nichtich added the cleanup code cleanup, refactoring, testing... label May 22, 2023
@nichtich nichtich modified the milestones: 1.10.0, 1.11.0 Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup code cleanup, refactoring, testing...
Projects
None yet
Development

No branches or pull requests

2 participants