Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Node.js 18 (and release a new major version) #195

Closed
6 tasks done
stefandesu opened this issue Apr 5, 2023 · 5 comments
Closed
6 tasks done

Require Node.js 18 (and release a new major version) #195

stefandesu opened this issue Apr 5, 2023 · 5 comments
Labels
cleanup dependencies Pull requests that update a dependency file
Milestone

Comments

@stefandesu
Copy link
Member

stefandesu commented Apr 5, 2023

The EOL of Node.js 16 is approaching (in September 2023), and Node.js 14 is almost EOL (end of April 2023), so it might be reasonable to skip both of those and require Node.js 18 for JSKOS Server. For this, we should release a new major version, i.e. version 2.0.0.

I'm not sure if there are other breaking changes that we could include in this release. @nichtich?

@stefandesu stefandesu added cleanup dependencies Pull requests that update a dependency file labels Apr 5, 2023
@stefandesu stefandesu added this to the 2.0.0 milestone Apr 5, 2023
stefandesu added a commit that referenced this issue Apr 12, 2023
@stefandesu
Copy link
Member Author

I think we'll be able to release it next week. 👍

@stefandesu
Copy link
Member Author

stefandesu commented Apr 21, 2023

To-Dos before release

  • Do some manual integration testing with Cocoda, Login Server, and maybe BARTOC
  • Prepare release notes
  • Question: Can we adjust our automatic updates that they won't do major updates without confirmation?

To-Dos after release

  • Import mismatch vocabulary into our main instances
  • Adjust config to allow using mismatch vocabulary
  • Make necessary adjustments in cocoda-sdk and release a new major version
  • Check for required adjustments in other projects (BARTOC in particular)
    • Should be fine as long as updated cocoda-sdk is used
  • Check whether everything works in our release instances

@stefandesu
Copy link
Member Author

Suggestion for release notes (note that links don't work until the release is out):

Breaking Changes

Further Changes

@stefandesu
Copy link
Member Author

v2.0.0 is now released: https://github.com/gbv/jskos-server/releases/tag/v2.0.0

I noticed a small issue that I fixed in v2.0.1: https://github.com/gbv/jskos-server/releases/tag/v2.0.1

This release also caused Cocoda to stop working until I updated it because it increased the API version to 2.0 as well, and Cocoda was configured to only support JSKOS API 1.0. This also means that none if the Cocoda versions in our archive work anymore which is a bit sad. Any ideas @nichtich? Related: #201 (One workaround could be to rebuild all Cocoda versions in our archive to skip the JSKOS API version check...)

@stefandesu
Copy link
Member Author

One workaround could be to rebuild all Cocoda versions in our archive to skip the JSKOS API version check...

This is probably a one-liner fix + rebuild of all old version for the archive, but currently not a priority.

Make necessary adjustments in cocoda-sdk and release a new major version

I had this on the to-do list here, but since it's not related to jskos-server itself, I created a separate issue over in cocoda-sdk.

With this, I'm finally closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

1 participant