Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include modification date #25

Closed
nichtich opened this issue Aug 25, 2022 · 4 comments
Closed

Include modification date #25

nichtich opened this issue Aug 25, 2022 · 4 comments

Comments

@nichtich
Copy link
Member

The API results are dated. At the moment the dump is from 2022-06-30, so this date should be included in responses. See also #24 to increase update frequency.

@nichtich
Copy link
Member Author

Could be part of #27.

@stefandesu
Copy link
Member

Should the date be the import date? What if the imported dump is actually older than the import date?

@nichtich
Copy link
Member Author

Modification date taken in this order:

  • explicit date given to update script via command line script (e.g. --modified)
  • else if import file given explicitly to import script (no import from stdin): use date of timestamp of import file
  • else use current date

The date should best persitently be stored by the backend (in SQL database or in a file)

@stefandesu
Copy link
Member

Now added in import script and API results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants