Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format: textarea について #18

Open
vvakame opened this issue Jul 18, 2019 · 3 comments
Open

format: textarea について #18

vvakame opened this issue Jul 18, 2019 · 3 comments
Assignees
@tenntenn

Comments

@vvakame
Copy link
Member

vvakame commented Jul 18, 2019

hake/json_column.go

Lines 114 to 116 in d268087

case gspanner.TypeCode_BYTES:
o.Set("type", "string")
o.Set("format", "textarea")

ここのtextareaってspecはどこでしょうか？(有名な方言だったりするのかしら
@vvakame
Copy link
Member Author

vvakame commented Jul 18, 2019

https://json-schema.org/understanding-json-schema/reference/string.html
よく見ると datetime も date-time ですね 🤔

@vvakame
Copy link
Member Author

vvakame commented Jul 18, 2019

https://swagger.io/docs/specification/data-models/data-types/#string
swaggerの拡張に従うと BYTES は byte みたいですね。
swaggerの拡張に従うというキメにしたほうがよい気がします。(通常のJSON Schemaだと表現力が弱い…

@vvakame
Copy link
Member Author

vvakame commented Jul 18, 2019

#17 のint64も解決方法がなかなか難しい…

@vvakame vvakame mentioned this issue Jul 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tenntenn tenntenn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vvakame @tenntenn