-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make CORNERSTONE package support all the different pdks #29
Changes from 4 commits
8852cae
742f254
1bbe7a5
0710533
e50976a
71d35ad
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,42 +0,0 @@ | ||
from gdsfactory.cross_section import get_cross_sections | ||
from gdsfactory.get_factories import get_cells | ||
from gdsfactory.pdk import Pdk | ||
|
||
from cspdk import cells, config, tech | ||
from cspdk.cells import _bend, _straight, _taper | ||
from cspdk.config import PATH | ||
from cspdk.models import get_models | ||
from cspdk.tech import LAYER, LAYER_STACK, LAYER_VIEWS, routing_strategies | ||
|
||
_models = get_models() | ||
_cells = get_cells(cells) | ||
_cells.update( | ||
{ | ||
"_straight": _straight, | ||
"_bend": _bend, | ||
"_taper": _taper, | ||
} | ||
) | ||
_cross_sections = get_cross_sections(tech) | ||
PDK = Pdk( | ||
name="cornerstone", | ||
cells=_cells, | ||
cross_sections=_cross_sections, | ||
layers=dict(LAYER), | ||
layer_stack=LAYER_STACK, | ||
layer_views=LAYER_VIEWS, | ||
models=_models, | ||
routing_strategies=routing_strategies, | ||
) | ||
PDK.activate() | ||
|
||
__all__ = [ | ||
"LAYER", | ||
"LAYER_STACK", | ||
"LAYER_VIEWS", | ||
"PATH", | ||
"cells", | ||
"config", | ||
"tech", | ||
] | ||
__version__ = "0.7.0" | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
from gdsfactory.cross_section import get_cross_sections | ||
from gdsfactory.get_factories import get_cells | ||
from gdsfactory.pdk import Pdk | ||
|
||
from cspdk.si220 import cells, config, tech | ||
from cspdk.si220.cells import _bend, _straight, _taper | ||
from cspdk.si220.config import PATH | ||
from cspdk.si220.models import get_models | ||
from cspdk.si220.tech import LAYER, LAYER_STACK, LAYER_VIEWS, routing_strategies | ||
|
||
_models = get_models() | ||
_cells = get_cells(cells) | ||
_cells.update( | ||
{ | ||
"_straight": _straight, | ||
"_bend": _bend, | ||
"_taper": _taper, | ||
} | ||
) | ||
_cross_sections = get_cross_sections(tech) | ||
PDK = Pdk( | ||
name="cornerstone", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is no longer a good, distinctive pdk name. what if we make it mirror the package name, i.e. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, fixed now, i named it cornerstone_si220, cornerstone_sin300 ... and so on |
||
cells=_cells, | ||
cross_sections=_cross_sections, | ||
layers=dict(LAYER), | ||
layer_stack=LAYER_STACK, | ||
layer_views=LAYER_VIEWS, | ||
models=_models, | ||
routing_strategies=routing_strategies, | ||
) | ||
PDK.activate() | ||
|
||
__all__ = [ | ||
"LAYER", | ||
"LAYER_STACK", | ||
"LAYER_VIEWS", | ||
"PATH", | ||
"cells", | ||
"config", | ||
"tech", | ||
] | ||
__version__ = "0.7.0" |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
sample_pads = """ | ||
name: pads | ||
pdk: cspdk | ||
pdk: cspdk.si220 | ||
|
||
instances: | ||
bl: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (testing): Missing tests for new module structure.
The PR introduces a new module structure under 'cspdk.si220'. It's crucial to add tests to verify that the new imports and module paths are correctly set up and functional.