Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gdsfactory 8.21.0 #78

Merged
merged 2 commits into from
Nov 28, 2024
Merged

update gdsfactory 8.21.0 #78

merged 2 commits into from
Nov 28, 2024

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Nov 28, 2024

Summary by Sourcery

Update the gdsfactory dependency to version 8.21.0 and refactor code to consistently use 'gf.Component' as the return type for component functions. Enhance test coverage by adding new test configurations for the 'compass' component and updating existing tests for the 'rectangle' component to include layer information.

Enhancements:

  • Update function return types to use 'gf.Component' instead of 'Component' for consistency and clarity across multiple files.

Build:

  • Upgrade gdsfactory dependency from version 8.20.0 to 8.21.0 in the pyproject.toml file.

Tests:

  • Add new test configurations for the 'compass' component across different technology nodes, including si220, si500, and sin300.
  • Update test configurations for the 'rectangle' component to include layer information in the name across different technology nodes.

Copy link

sourcery-ai bot commented Nov 28, 2024

Reviewer's Guide by Sourcery

This PR updates the gdsfactory dependency to version 8.21.0 and makes corresponding type annotation changes. It also adds a new compass component and modifies the rectangle component to accept an explicit layer parameter.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated return type annotations from Component to gf.Component
  • Changed return type annotations in all component functions
  • Updated type hints to be more explicit and consistent
cspdk/si220/cells/primitives.py
cspdk/si500/cells.py
cspdk/sin300/cells.py
Added new compass component for creating rectangles with ports on each edge
  • Added compass function with configurable size, layer, and port settings
  • Implemented port orientation and type configuration
  • Added corresponding test files for the new component
cspdk/si220/cells/primitives.py
cspdk/si500/cells.py
cspdk/sin300/cells.py
tests/test_si220/test_settings_compass_.yml
tests/test_si500/test_settings_compass_.yml
tests/test_sin300/test_settings_compass_.yml
Modified rectangle component to accept explicit layer parameter
  • Changed rectangle function signature to take layer as a named parameter
  • Updated default layer to FLOORPLAN
  • Updated corresponding test files with new component naming
cspdk/si220/cells/primitives.py
cspdk/si500/cells.py
cspdk/sin300/cells.py
tests/test_si220/test_settings_rectangle_.yml
tests/test_si500/test_settings_rectangle_.yml
tests/test_sin300/test_settings_rectangle_.yml
Updated gdsfactory dependency version
  • Bumped gdsfactory version from 8.20.0 to 8.21.0
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@joamatab joamatab changed the title update gdsfactory update gdsfactory 8.21.0 Nov 28, 2024
@joamatab joamatab added the dependencies Pull requests that update a dependency file label Nov 28, 2024
@joamatab joamatab merged commit 5bcd0af into main Nov 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant