From d0c6fc77d2ff1fccacba536086b0f1a8dbf21e93 Mon Sep 17 00:00:00 2001
From: Sebastian Goeldi <sgoeldi@psiquantum.com>
Date: Mon, 18 Sep 2023 20:25:33 +0200
Subject: [PATCH 1/2] add function_name to settings when using @cell; closes
 #180

---
 demo.gds                | Bin 0 -> 2892 bytes
 docs/mkdocs.yml         |   1 +
 docs/source/dosdonts.md |   9 +++++++++
 src/kfactory/kcell.py   |   2 ++
 4 files changed, 12 insertions(+)
 create mode 100644 demo.gds
 create mode 100644 docs/source/dosdonts.md

diff --git a/demo.gds b/demo.gds
new file mode 100644
index 0000000000000000000000000000000000000000..85006bad80103c622bd085fce58ae3c3f9839c87
GIT binary patch
literal 2892
zcmbW(4`|e79LMqJ_wTt=H+4%iY~sbVo4RhlTdr-_6t}r-IcMoaG3z*Qzpb<1?vDFY
zF0>FM$VxFN5|Kt3(H{(n%)qceQbC9n31yH_Mqt=qDEedT{oL<11HEH3czk*I{C>~p
z`+c50o{&P<H;5Wd7o~puy6oxh5MqX5Ep30KdFA^r{M5SqXv4_<jeVlVD*fC{Dd)|b
z*SWg4uWLhJw7d7_)qE7@WFhLRWrvgO@5;MQCc55EH$~Tkqdj)Ct2dQ&qV26VpPOtU
zDyAFbq2wZ6REvf6a#dGfdtLCJfml43$_z)cPA->74rU|wCHixB2Nx`<t+hi<La6yw
z;;z#3vyMB!^kCcAt3q+db+aKyr3#Jb3#2x0apJi^EEll1HV^b~4!1NlwzMv`mj(-K
zOc$ZjYh;{k%FX8zsiX?#s-je`X`-&oGqL_eKI_dd%${0qwi_FEGKI<XOTD{NtSSBO
zfqXKq(nOQ7Ax9NIUS{cS2zu|WC|9SGjJv69K2vz7+C;B6Q_3ZeB?nzKzt(N_x-$6+
zv(u?eE*lA7+FZBE_GV8K_GNXB%~nQp!|6htR63W4$6POwUtCx6sj;4<8ojx`GI_?@
z9t=0w-fSt_O1`;2o_4oJbD3CD?Q1a8Y6ljE1L06hbG`bb*kP;WdiE9SH?OcCUj26D
z(n{eLJ7Cunv2Zqwl0CB{rF*8A?3o=I?^)REf>x%6%X=n7eZB1L>gicBfpaL#Dj`gt
zD0}DB$%)-8rk{>f>OvE8DmR$5&AVwvM@MDx#`zPUVJP2Z{KdH7sS!f_Erb@pix?@o
z7XRV%5RT%*42{8i)cvX*WtfbQ8J6JU#Ys3DE3gr#;{7-apTKMIMVyQ8U@d-*Y^gz3
zEsQmIBi?{*n8#k+h3jwxH{n^#;jg%jX7X-rH-_+O?7(M{XS7#v5Z}OIWNq_NJc$R8
z4CWy`hsW_}JcabbWF4Jr-uw}-MtY*pr^}T{MoZPyj?Eaw+wnoX6Zha2B(rrd9>yK`
z9zKqzk*xZ6NLHQwvB+xBKkEnv@NHD<e2RDA8BF6h_z<4QefSGfgY^fV;6Moc0{M$U
zc1d27eUjBkW~pjv#5s5ivIiy^<su}TY{2J{wasHledcGlj5TVI{#uK%3wy8|AHbFP
z6t2P#aW#I8^hM4n${xuzj1`Qvj9Aepv5)bpr>|ECKiS5VFY{SFv#00=T+U|`J6VT5
z`qf_Wy#FRt|K5siNPcTBl3D#f?+;VYIlLY}z=ik{vbW}AcrB)oT1~S1XCcq}t8gYx
zp|AAXPfv|6$;i1d-ooE;1j%Cb<5x&#AA4;qz>kpq^|7z|5BNHMf~>8-h6j-T`S#*4
z?!--)$7MK(wMaeMDI~9^p1TS;OFn_y>B$9*BWFNkZ{!JVK<235bGZY*#RQ&2Y7|G1
z9*JE@U4k{O?=gmC6zqpOmqPV+KT?mySr_!iTETro?bbA8P4hI;5A!G<#{GB@x8pwS
zL~1kVBX@-9L(a8v9;wkdgzIrH-iBGE4r3j5Vhb+8*+?(+i^zG_&mw!Ozl-G44<bF%
zx8NMKk-XY5oQ5M<i93;f(FT#d)o#VfSdCn;;<ut_P&N5@(dSV8vWbEdxz}e%Ih4p`
uQkkf;H8zxX9gfxi{U%vhkC+qv7Aj|JM6IZ?IyS1z{QUQO=~#Nx6#oM5VQU=#

literal 0
HcmV?d00001

diff --git a/docs/mkdocs.yml b/docs/mkdocs.yml
index 481bba71..a535c2cd 100644
--- a/docs/mkdocs.yml
+++ b/docs/mkdocs.yml
@@ -7,6 +7,7 @@ nav:
   - Home:
     - Intro: index.md
     - gdsfactory.md
+    - dosdonts.md
   - First Steps:
     - Prerequisites: pre.md
     - 5min Intro to KFactory: intro.md
diff --git a/docs/source/dosdonts.md b/docs/source/dosdonts.md
new file mode 100644
index 00000000..e19989ff
--- /dev/null
+++ b/docs/source/dosdonts.md
@@ -0,0 +1,9 @@
+# Dos and Don'ts
+
+
+## Dos
+
+## Don'ts
+
+* Do not use "function_name" as a function parameter when using `@kf.cell` decorator,
+  it will be overwritten by the function name used to create the cell
diff --git a/src/kfactory/kcell.py b/src/kfactory/kcell.py
index 1e08542a..fedf380d 100644
--- a/src/kfactory/kcell.py
+++ b/src/kfactory/kcell.py
@@ -3520,6 +3520,8 @@ def wrapped_cell(
                 if set_settings:
                     settings = cell.settings.model_dump()
                     settings.update(params)
+                    if set_name:
+                        settings["function_name"] = name
                     cell._settings = KCellSettings(**settings)
                 info = cell.info.model_dump()
                 for name, value in cell.info:

From 7cb5026a33aa5454fbba4c246b37a3c9f5c14dd3 Mon Sep 17 00:00:00 2001
From: Sebastian Goeldi <sgoeldi@psiquantum.com>
Date: Mon, 18 Sep 2023 20:27:29 +0200
Subject: [PATCH 2/2] towncrier update

---
 changelog.d/180.added.md | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 changelog.d/180.added.md

diff --git a/changelog.d/180.added.md b/changelog.d/180.added.md
new file mode 100644
index 00000000..c798eaaa
--- /dev/null
+++ b/changelog.d/180.added.md
@@ -0,0 +1 @@
+Added  to be set by  decorator
\ No newline at end of file