Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in the get_eastern_map function #56

Open
mcmccue1 opened this issue Nov 11, 2019 · 0 comments
Open

Issue in the get_eastern_map function #56

mcmccue1 opened this issue Nov 11, 2019 · 0 comments

Comments

@mcmccue1
Copy link

mcmccue1 commented Nov 11, 2019

I downloaded the package onto my windows pc using R studio version 3.6.1 and tested the map_counties examples to run. None of them ran.

I pulled down the code, and saw that the issue was in the get_eastern_map function, when combining the region and subregion as a identifier for the left join. The fix was to remove the from argument.

In addition, I would recommend implementing some unit tests, as the get_eastern_map function seems to be a frequently used function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant