Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(idea/frontend): validate ss58 address length #1680

Open
nikitayutanov opened this issue Nov 29, 2024 · 0 comments
Open

fix(idea/frontend): validate ss58 address length #1680

nikitayutanov opened this issue Nov 29, 2024 · 0 comments
Assignees
@nikitayutanov
Labels
C0-bug Something isn't working D1-idea Gear Idea

Comments

@nikitayutanov
Copy link
Member

Problem

Take a look at:

gear-tech/gear-bridges#222
gear-tech/gear-bridges#224

The correct way to validate ss58 is to try to encode it alongside with decoding. Currently, IDEA only relies on decoding.

Steps

  1. Open Transfer Balance modal
  2. Paste any Ethereum based hex wallet address
  3. No validation error

Possible Solution

Perhaps would be useful to create a shared util in @gear-js/react-hooks.

Notes

No response

Relevant Log Output

No response
@nikitayutanov nikitayutanov added C0-bug Something isn't working D1-idea Gear Idea labels Nov 29, 2024
@nikitayutanov nikitayutanov self-assigned this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikitayutanov nikitayutanov

Labels
C0-bug Something isn't working D1-idea Gear Idea
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nikitayutanov