Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor issue - e2label #7

Open
bclaymiles opened this issue Feb 18, 2024 · 2 comments · May be fixed by #16
Open

Minor issue - e2label #7

bclaymiles opened this issue Feb 18, 2024 · 2 comments · May be fixed by #16

Comments

@bclaymiles
Copy link

I'm using f2fs on one of my pi's, and each time rpi-clone runs, it reports:

Editing /mnt/clone/etc/fstab PARTUUID to use ea0b56b4
e2label: Bad magic number in super-block while trying to open /dev/sda2

Which makes sense, since you can't add an extX label to an f2fs filesystem. I've tested the backups, they work fine, so this is a cosmetic error at worst.
@bclaymiles
Copy link
Author

I should probably add - the script is invoked nightly as:
/usr/local/sbin/rpi-clone -u -v sda
So I'm not declaring that a label should be written. Likewise, the logic in the script appears to suggest that it should not be trying to write a label on a non ext filesystem, which is why this appears to be a bug. However, I'm not a coder, so my interpretation of what the script is doing may be faulty.

@matthijskooijman
Copy link

Seems the problem is that the code assumes the rootfs is ext. This is fixed as a side effect of my PR #16.

@matthijskooijman matthijskooijman linked a pull request Apr 5, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Keep filesystem labels matthijskooijman/rpi-clone
2 participants
@matthijskooijman @bclaymiles