Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawing (cropsize) doesn't work on rectangles (not square) #21

Closed
bernatripoll opened this issue May 15, 2013 · 1 comment
Closed

Drawing (cropsize) doesn't work on rectangles (not square) #21

bernatripoll opened this issue May 15, 2013 · 1 comment

Comments

@bernatripoll
Copy link

Hello! this problem happens when the crop size is not a square, like for example 320x80.

  • you just pick a photo (no zoom, no moves), then click crop and the result is the original picture.
  • Even if you move the photo still not working, I mean it creates a result image but it's not what you selected.

Any suggestions?

Thanks!

gekitz added a commit that referenced this issue May 19, 2013
this fixes the issue where a landscape croparea did work. thanks
@ziweizhou for fixing this!
@gekitz gekitz closed this as completed May 19, 2013
@joshbernfeld
Copy link

This has resulted in problems when cropping to squares (and maybe more not sure).
See issue #23

Scale is now sometimes determined for the wrong axis because image scale should be based on image width and height, NOT crop width and height.

instead of this

if (self.cropSize.width > self.cropSize.height)

change it to this

if (self.imageToCrop.size.width > self.imageToCrop.size.height)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants