We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a configuration file instead of flags
Currently, the code uses flags for configuration, which are defined in train.py. This approach has limitations:
Implement a configuration system using a library like hydra or OmegaConf. This would allow:
hydra
OmegaConf
Example:
# Top-level configuration mode: train # Data configuration data: path: /path/to/your/data batch_size: 2 noise_std: 6.7e-4 # Model configuration model: path: models/ file: null train_state_file: train_state.pt # Output configuration output: path: rollouts/ filename: rollout # Training configuration training: steps: 20000000 validation_interval: null save_steps: 5000 learning_rate: initial: 1e-4 decay: 0.1 decay_steps: 5000000 # Hardware configuration hardware: cuda_device_number: null n_gpus: 1 # Logging configuration logging: tensorboard_dir: logs/ constants: input_sequence_length: 6 num_particle_types: 9 kinematic_particle_id: 3
Why should we not do this? Please consider the impact on users, Breaking change on existing workflow.
Why is this design the best in the space of possible designs?
What other designs have been considered and what is the rationale for not choosing them?
What is the impact of not doing this?
What parts of the design do you expect to resolve through the RFC process before this gets merged?
The text was updated successfully, but these errors were encountered:
Fixed in #81
Sorry, something went wrong.
kks32
yjchoi1
No branches or pull requests
Configuration Management
Summary
Motivation
Currently, the code uses flags for configuration, which are defined in train.py. This approach has limitations:
Design Detail
Implement a configuration system using a library like
hydra
orOmegaConf
. This would allow:Example:
Drawbacks
Rationale and Alternatives
Unresolved questions
Changelog
The text was updated successfully, but these errors were encountered: