-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
render rollout merge #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- You need to update readme.
- Write a test to see if rollouts are predicted correctly
- Don't you need to update or define the hydra configs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Document all your functions properly using docstrings -- Google style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactor the code and be consistent, improve readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the black failures, then we should be good to merge
Objective:
This RFP proposes to integrate the execution of rollout prediction and rendering function. It should also provide an option to disable the automatic rendering
Current System:
Currently, the user has to execute rollout prediction and rendering through separate commands.
Proposed Changes:
Expected Challenges:
Testing Plan:
The following steps are used to test the functioning of rendering function in gns/train.py script,