From c82efe7f86565bde1cf2c0a1d8b48ee728dc86ac Mon Sep 17 00:00:00 2001
From: Florian Necas <florian.necas@camptocamp.com>
Date: Thu, 21 Sep 2023 09:04:01 +0200
Subject: [PATCH 1/2] feat: add legacy option to display iframe

---
 README.md         |  6 ++++++
 src/header.ce.vue | 11 ++++++++++-
 2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/README.md b/README.md
index 4dcf940..d31bc24 100644
--- a/README.md
+++ b/README.md
@@ -24,6 +24,12 @@ To include it in an existing application:
 
 Note: unlike with iframes there is no need to specify a height, the component will decide of its own size and "push" the content around accordingly.
 
+Iframe can still be set with defining `legacy_url` attribute, style can also be set with `legacy_style` attribute :
+  ```html
+  <geor-header legacy_url="myheader.com" legacy_style="width: 100%"></geor-header>
+  ```
+ 
+
 ## Development
 
 On every new commit on main the `header.js` file on the `dist` branch is updated automatically.
diff --git a/src/header.ce.vue b/src/header.ce.vue
index 1a4cd0f..135c0de 100644
--- a/src/header.ce.vue
+++ b/src/header.ce.vue
@@ -7,6 +7,9 @@ import UserIcon from './ui/UserIcon.vue'
 const props = defineProps<{
   lang?: string
   activeApp?: string
+  //legacy option : using old iframe option
+  legacy_url?: string
+  legacy_style?: string
 }>()
 
 const state = reactive({
@@ -31,7 +34,13 @@ onMounted(() => {
 })
 </script>
 <template>
-  <header class="host">
+  <div v-if="props.legacy_url">
+    <iframe
+      v-bind:src="props.legacy_url"
+      v-bind:style="props.legacy_style"
+    ></iframe>
+  </div>
+  <header v-if="!props.legacy_url" class="host">
     <div
       class="admin pr-8 items-center bg-primary/20 text-secondary/80 flex justify-end gap-5 text-sm font-sans"
       v-if="isAdmin"

From 998df03bd94e88796aa4307f485c7bcaf85b8ded Mon Sep 17 00:00:00 2001
From: Florian Necas <florian.necas@camptocamp.com>
Date: Mon, 9 Oct 2023 16:05:22 +0200
Subject: [PATCH 2/2] feat: taking account of recommandation from @tkohr

---
 README.md         |  4 ++--
 src/header.ce.vue | 12 ++++++------
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/README.md b/README.md
index d31bc24..1e1910e 100644
--- a/README.md
+++ b/README.md
@@ -24,9 +24,9 @@ To include it in an existing application:
 
 Note: unlike with iframes there is no need to specify a height, the component will decide of its own size and "push" the content around accordingly.
 
-Iframe can still be set with defining `legacy_url` attribute, style can also be set with `legacy_style` attribute :
+Iframe can still be set with defining `legacy-url` attribute, style can also be set with `legacy-style` attribute :
   ```html
-  <geor-header legacy_url="myheader.com" legacy_style="width: 100%"></geor-header>
+  <geor-header legacy-url="myheader.com" legacy-style="width: 100%"></geor-header>
   ```
  
 
diff --git a/src/header.ce.vue b/src/header.ce.vue
index 135c0de..85f88cd 100644
--- a/src/header.ce.vue
+++ b/src/header.ce.vue
@@ -8,8 +8,8 @@ const props = defineProps<{
   lang?: string
   activeApp?: string
   //legacy option : using old iframe option
-  legacy_url?: string
-  legacy_style?: string
+  legacyUrl?: string
+  legacyStyle?: string
 }>()
 
 const state = reactive({
@@ -34,13 +34,13 @@ onMounted(() => {
 })
 </script>
 <template>
-  <div v-if="props.legacy_url">
+  <div v-if="props.legacyUrl">
     <iframe
-      v-bind:src="props.legacy_url"
-      v-bind:style="props.legacy_style"
+      v-bind:src="props.legacyUrl"
+      v-bind:style="props.legacyStyle"
     ></iframe>
   </div>
-  <header v-if="!props.legacy_url" class="host">
+  <header v-if="!props.legacyUrl" class="host">
     <div
       class="admin pr-8 items-center bg-primary/20 text-secondary/80 flex justify-end gap-5 text-sm font-sans"
       v-if="isAdmin"