Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lidar render for novel view #43

Open
szhang963 opened this issue Jul 29, 2024 · 4 comments
Open

lidar render for novel view #43

szhang963 opened this issue Jul 29, 2024 · 4 comments

Comments

@szhang963
Copy link

Hi, thanks for your excellent work.
I would like to know whether you will support lidar render for novel view, specifically to implement the function _generate_rays_from_coords for lidar modeling.
Best.

@carlinds
Copy link
Collaborator

Lidar rendering is already supported for novel views, it is the same for novel views as for training views. You just need to specify a lidar at a novel view and then run pipeline.model.get_outputs_for_lidar(lidar, batch=batch). You can get some inspiration by looking at our dataset render:
https://github.com/georghess/neurad-studio/blob/main/nerfstudio/scripts/render.py#L1157

@atonderski
Copy link
Collaborator

To clarify: the way it is implemented in the render relies on the dataparser having inferred the missing points to create a complete point cloud where missing rays are represented by dummy points. It would be valuable to implement the functionality you request, where you don't need a dummy point cloud but can instead generate rays directly from a lidar model, but we haven't had time to implement this properly. There is some semblance of what you are asking for in the viewer lidar rendering code:
https://github.com/georghess/neurad-studio/blob/5101feee192947b372cc2471364163fe327783ae/nerfstudio/viewer/render_state_machine.py#L361C7-L361C20

@atonderski
Copy link
Collaborator

This part could definitely use some love, but I don't foresee us cleaning this up anytime soon unfortunately :/ If you end up implementing something for _generate_rays_from_coords it would be very welcome of course!

@szhang963
Copy link
Author

Thank you for your useful guidance, and I will try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants